Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional K-factor to Dynamic #901

Merged
merged 3 commits into from Sep 17, 2022
Merged

add optional K-factor to Dynamic #901

merged 3 commits into from Sep 17, 2022

Conversation

DaveSkender
Copy link
Owner

Description

Add optional kFactor parameter to McGinley Dynamic; resolve #897

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have put comments in my code, particularly for hard-to-understand areas
  • I have performed a self-review of my code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings or other code analysis issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@DaveSkender DaveSkender marked this pull request as ready for review September 17, 2022 21:56
@DaveSkender DaveSkender enabled auto-merge (squash) September 17, 2022 22:02
@DaveSkender DaveSkender changed the title Add k add optional K-factor to Dynamic Sep 17, 2022
@DaveSkender DaveSkender merged commit cfc8471 into main Sep 17, 2022
@DaveSkender DaveSkender deleted the add-k branch September 17, 2022 22:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

k value as variable in McGinley Dynamic
1 participant