Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: public TQuote sort utility #976

Merged
merged 2 commits into from Dec 24, 2022
Merged

fix: public TQuote sort utility #976

merged 2 commits into from Dec 24, 2022

Conversation

DaveSkender
Copy link
Owner

@DaveSkender DaveSkender commented Dec 20, 2022

Description

Adding back the missing quote sorter utility interface

Fixes #975

To do

  • add unit tests
  • consider single pass transform to Collection --> not better than current

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have put comments in my code, particularly for hard-to-understand areas
  • I have performed a self-review of my code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings or other code analysis issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@DaveSkender DaveSkender marked this pull request as ready for review December 24, 2022 21:07
@DaveSkender DaveSkender merged commit 6eb128a into main Dec 24, 2022
@DaveSkender DaveSkender deleted the fix-interface branch December 24, 2022 21:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToSortedCollection not working for TQuote
1 participant