Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piwigo #475

Merged
merged 7 commits into from
Dec 13, 2021
Merged

Piwigo #475

merged 7 commits into from
Dec 13, 2021

Conversation

Narcolapser
Copy link

What this PR does / why we need it:

Add's Piwigo Photo Gallery.

Toben Archer added 6 commits August 9, 2021 10:36
I've created the Role but I do not yet know if it will work.
But I still need to do some tweaks yet.
The container now shows up in traefik correctly. But now it looks
like I may need to setup a database container.
Now I need to add all the administrative bits for ansible-nas. I
would also like to set it up to pre-populate the configuration
information for the database like gitea does. I'll have to read a
few more docs for that. But the important part is this is up now.
piwigo_photos: "{{ photos_root }}/piwigo"

# uid / gid
piwigo_user_id: "1000"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 0?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently not, quoth https://hub.docker.com/r/linuxserver/piwigo

docker run -d \
  --name=piwigo \
  -e PUID=1000 \
  -e PGID=1000 \
  -e TZ=Europe/London \
  -p 80:80 \
  -v </path/to/appdata/config>:/config \
  -v </path/to/appdata/gallery>:/gallery \
  --restart unless-stopped \
  ghcr.io/linuxserver/piwigo

It does seem strange though. I just logged into the container and it is running as root, but the nginx and php processes are running as user "abc" which is UID of 1000. Can never have to much security I guess?


# uid / gid
piwigo_user_id: "1000"
piwigo_group_id: "1000"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this?

@davestephens
Copy link
Owner

Looks good, thanks for the contribution!

The only thing that needs some attention is the uid/gid - root is 0, and first non-root 1000 so not sure what you're aiming for here.

@Narcolapser
Copy link
Author

Narcolapser commented Sep 13, 2021

Just reminding you this is still dandling. The uid/gid thing appears to be how the container maintainers intended it. So I stuck with their guidance. It wouldn't be the first container to do such, currently the grafana container uses the "grafana" user which is 472 in my container. In this case it appears to be running the service as the user "abc". I can change it to be consistent with how some of the other containers have been formatted, but I recommend sticking with what the container maintainers recommend.

@Narcolapser
Copy link
Author

I ran across something else a while back that explained gid and uid, I agree, those should have been 0. I have updated them so this should be ready to merge now.

@davestephens davestephens merged commit 5bb08d9 into davestephens:master Dec 13, 2021
@seeReadCode
Copy link

My experience: using 0 for the PUID and PGID generates a 502 and this error: please specify user and group other than root. Using 1000 allows piwigo to actually load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants