Observations with $current N/A values are not shown anymore in stat-tiles/conditions table on day page

[Daveiano]

I noticed the change on the tiles.
I use several data sources for my weewx site.
1 - an SDR receiver to process data received by radio
2 - From my bresser station which I capture via wifi.
Sometimes the data is not captured during the capture interval.

In versions 3.2.0 and earlier, I had NA values when data could not be received. In the tiles, the NA value was displayed along with the day's min and max values for the capture interval where the value is missing.
Now, with version 3.3.0, when a value is NA, it is no longer displayed in the tiles.
I was wondering if there was now a parameter that managed the display of NA values in tiles?

Originally posted by @endmarsfr in #183 (comment)

---

Ah ok, I understood. You are right, this changed since the last version: The condition is now if $current.obs.has_data, instead of $day.obs.has_data. To be honest, I thought it would be better to check against $current, but you are right. Since the min/max value of the day is shown, it absolutely makes sense to check against $day to determine if the observations should be shown.

I don't think it makes sense to make this configurable since it definitely should use $day in that case, or what do you think?

Note to myself: https://github.com/Daveiano/weewx-wdc/blob/3.x/skins/weewx-wdc/includes/conditions-table.inc#L66 and https://github.com/Daveiano/weewx-wdc/blob/3.x/skins/weewx-wdc/includes/body-alternative.inc#L74

Originally posted by @Daveiano in #183 (comment)

---

I think that if the "show_min_max_time_day" option is set to True, it is mandatory to display the values even if they are NA. Indeed, with the current behavior, the min/max values are lost.

But if the "show_min_max_time_day" option is set to false, it might be more useful to hide the NA values.

But if these rules can't be applied, I prefer to revert to the previous behavior and use: "$day.obs.has_data" in the templates.

Originally posted by @endmarsfr in #183 (comment)

[Daveiano]

@endmarsfr I implemented the change in 717eed4. You can test this out by using the updated templates skins/weewx-wdc/includes/body-alternative.inc and skins/weewx-wdc/includes/conditions-table.inc.

A slight change: I made the display not dependent on show_min_max_time_day, but on stat_tiles_show_min, stat_tiles_show_max or stat_tiles_show_sum. So if the max, min or sum of an observations should be displayed it will check against $day, if not It will check against $current. I think this makes more sense!?

[Daveiano]

My bad, I made a copy/paste error in skins/weewx-wdc/includes/body-alternative.inc, please see the following change: eabad0f

[Daveiano]

I will close this for now, feel free to open another issue if you encounter any problems!