Add support for g4 can2 and can3 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietgeursen
force-pushed
the
g474_has_can2
branch
from
16dec5d
to
4e68220
Compare
|
Great stuff. Of note, I use G4 with CAN a lot, but I unfortunately, the transceiver is wired to CAN1 on all the boards, so can't help test. |
pietgeursen
force-pushed
the
g474_has_can2
branch
from
1d4aa8f
to
803fa95
Compare
|
Is this now ready for review? |
|
Yep!
…On Thu, 2 May 2024, 6:50 am David-OConnor, ***@***.***> wrote:
Is this now ready for review?
—
Reply to this email directly, view it on GitHub
<#101 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACQRI6WL2LQBFSDI23245TDZAE2P3AVCNFSM6AAAAABG5WHF7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYHEYTMOBQGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Great stuff; well-researched. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CAN2 and CAN3 support for the G4 devices.
I have tested that FDCAN2 does actually send can frames. I haven't done more in-depth tests of FDCAN2 yet, or tested FDCAN3 but I feel like it's safe to assume that stuff will work.
The datasheet is a bit misleading. Table 3 would make you think the message ram is divided into 1K blocks.
But actually the blocks are smaller:
