Update MD011/no-reversed-links to remove RegExp negative lookbehind a…

…ssertion which is not supported on Safari.
DavidAnson · Aug 23, 2021 · e72b2ba · e72b2ba
1 parent a8228ec
commit e72b2ba
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 12 deletions.
diff --git a/demo/markdownlint-browser.js b/demo/markdownlint-browser.js
@@ -2257,7 +2257,7 @@ module.exports = {
 
 var _a = __webpack_require__(/*! ../helpers */ "../helpers/helpers.js"), addError = _a.addError, forEachLine = _a.forEachLine, overlapsAnyRange = _a.overlapsAnyRange;
 var _b = __webpack_require__(/*! ./cache */ "../lib/cache.js"), inlineCodeSpanRanges = _b.inlineCodeSpanRanges, lineMetadata = _b.lineMetadata;
-var reversedLinkRe = /(?<![\\\]])\(([^)]+)(?<!\\)\)\[([^\]^][^\]]*)(?<!\\)](?!\()/g;
+var reversedLinkRe = /(^|[^\\])\(([^)]+)\)\[([^\]^][^\]]*)](?!\()/g;
 module.exports = {
     "names": ["MD011", "no-reversed-links"],
     "description": "Reversed link syntax",
@@ -2268,11 +2268,13 @@ module.exports = {
             if (!inCode && !onFence) {
                 var match = null;
                 while ((match = reversedLinkRe.exec(line)) !== null) {
-                    var reversedLink = match[0], linkText = match[1], linkDestination = match[2];
-                    var index = match.index;
-                    var length_1 = match[0].length;
-                    if (!overlapsAnyRange(exclusions, lineIndex, index, length_1)) {
-                        addError(onError, lineIndex + 1, reversedLink, null, [index + 1, length_1], {
+                    var reversedLink = match[0], preChar = match[1], linkText = match[2], linkDestination = match[3];
+                    var index = match.index + preChar.length;
+                    var length_1 = match[0].length - preChar.length;
+                    if (!linkText.endsWith("\\") &&
+                        !linkDestination.endsWith("\\") &&
+                        !overlapsAnyRange(exclusions, lineIndex, index, length_1)) {
+                        addError(onError, lineIndex + 1, reversedLink.slice(preChar.length), null, [index + 1, length_1], {
                             "editColumn": index + 1,
                             "deleteCount": length_1,
                             "insertText": "[" + linkText + "](" + linkDestination + ")"

diff --git a/lib/md011.js b/lib/md011.js
@@ -6,7 +6,7 @@ const { addError, forEachLine, overlapsAnyRange } = require("../helpers");
 const { inlineCodeSpanRanges, lineMetadata } = require("./cache");
 
 const reversedLinkRe =
-  /(?<![\\\]])\(([^)]+)(?<!\\)\)\[([^\]^][^\]]*)(?<!\\)](?!\()/g;
+  /(^|[^\\])\(([^)]+)\)\[([^\]^][^\]]*)](?!\()/g;
 
 module.exports = {
   "names": [ "MD011", "no-reversed-links" ],
@@ -18,14 +18,18 @@ module.exports = {
       if (!inCode && !onFence) {
         let match = null;
         while ((match = reversedLinkRe.exec(line)) !== null) {
-          const [ reversedLink, linkText, linkDestination ] = match;
-          const index = match.index;
-          const length = match[0].length;
-          if (!overlapsAnyRange(exclusions, lineIndex, index, length)) {
+          const [ reversedLink, preChar, linkText, linkDestination ] = match;
+          const index = match.index + preChar.length;
+          const length = match[0].length - preChar.length;
+          if (
+            !linkText.endsWith("\\") &&
+            !linkDestination.endsWith("\\") &&
+            !overlapsAnyRange(exclusions, lineIndex, index, length)
+          ) {
             addError(
               onError,
               lineIndex + 1,
-              reversedLink,
+              reversedLink.slice(preChar.length),
               null,
               [ index + 1, length ],
               {