Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implicit conversion from value to Maybe #50

Merged
merged 1 commit into from Apr 23, 2018
Merged

Add implicit conversion from value to Maybe #50

merged 1 commit into from Apr 23, 2018

Conversation

DeafLight
Copy link
Contributor

Fixes a gap between what is described in the wiki (https://github.com/DavidArno/SuccincT/wiki/Maybe_T_#construction) and the actual behavior (compilation error when trying to implicitly convert a value to a Maybe).
Added the unit test that checks this behavior on both Option and Maybe.

@DeafLight
Add implicit conversion from value to Maybe
5e24d86 
Fixes a gap between what is described in the wiki (https://github.com/DavidArno/SuccincT/wiki/Maybe_T_#construction) and the actual behavior (compilation error when trying to implicitly convert a value to a Maybe).
Added the unit test that checks this behavior on both Option and Maybe.
@DeafLight DeafLight changed the base branch from master to v3.2 April 3, 2018 09:43
@DavidArno
Copy link
Owner

Note to self: review this soon. Maybe justified in pushing out a 3.1.1 bugfix release for this, rather than waiting for 4.0.

@DavidArno DavidArno changed the base branch from v3.2 to v3.1.1 April 23, 2018 12:05
@DavidArno DavidArno merged commit 4965e4b into DavidArno:v3.1.1 Apr 23, 2018
@DeafLight DeafLight deleted the maybe-implicit-conversion branch April 23, 2018 12:49
@DavidArno DavidArno mentioned this pull request May 11, 2018
Closed
@DavidArno DavidArno mentioned this pull request Jul 12, 2018
Closed
17 tasks
@DavidArno
Copy link
Owner

As part of merging this into v4, much of the change becomes redundant as Maybe<T> has been removed and Option<T> becomes a struct. The test added for Option<T> is kept.

DavidArno added a commit that referenced this pull request Nov 26, 2018
@DavidArno
#50 and #49. Merged the v3.3.1 branch.
1dc36c1 
This branch included the `HasValue` method for #49.
This branch also included the PR #50. But as `Maybe<T>` is now removed in the v8 branch, much of that PR becomes redundant and so has been removed.
DavidArno added a commit that referenced this pull request Nov 26, 2018
@DavidArno
#50 and #49. Merged the v3.3.1 branch. (part 2, as I still don't know…
1fbb2e6 
… how to use git properly)

This branch included the `HasValue` method for #49.
This branch also included the PR #50. But as `Maybe<T>` is now removed in the v8 branch, much of that PR becomes redundant and so has been removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DeafLight @DavidArno