Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenizeText func doesn't return all sentences #7

Open
koushki opened this issue Mar 4, 2019 · 2 comments
Open

TokenizeText func doesn't return all sentences #7

koushki opened this issue Mar 4, 2019 · 2 comments

Comments

@koushki
Copy link

koushki commented Mar 4, 2019

I expect text.parsedSentences should contain all sentences. let me explain the problem with code :)

place it in parse/tokenizer_test.go file

func TestTokenizeText(t *testing.T) {
	rule := NewRule()

	text := TokenizeText("Hi!!!", rule)
	assert.Equal(t, "Hi!", text.parsedSentences[0].original)
	assert.Equal(t, "!", text.parsedSentences[1].original)
	assert.Equal(t, "!", text.parsedSentences[2].original)
}

I expect this test should be passed, but apparently, it is not!

@rahulk0127
Copy link

Hi, I'm a beginner to open source. Could I have some pointers on where to start contributing to this project?

@DavidBelicza
Copy link
Owner

Hi,

Any contribution is welcome.

I recommend creating an issue here on GitHub then fork the repo and create a branch to that issue.

If you want to fix a logical error in the text ranking that's fine, but if you wish to add a new feature that should be discussed before.

I also recommend creating very small pull requests to make the whole process faster and more efficient.

Make sure GoReport is always on 100% https://goreportcard.com/report/github.com/DavidBelicza/TextRank and code coverage is near to 100% https://coveralls.io/github/DavidBelicza/TextRank?branch=master and please don't add 3rd party libraries to the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants