Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle Scala 3 nightly version for community build #18

Merged
merged 1 commit into from Jan 11, 2023

Conversation

ckipp01
Copy link
Contributor

@ckipp01 ckipp01 commented Oct 24, 2022

This was originally reported on Discord but it looks like the "unmanaged" community build is filtering out Mill projects that use mill-tpolecat, as you can see in
https://github.com/VirtusLab/community-build3/blob/927f3751011d120c52a5217dfe8ccd3321f49c42/env/prod/config/filtered-projects.txt#L66-L69. From the comment and from playing around it looks to be because if you have a NIGHTLY or RC or anything it will puke. This adds a fallback for Scala 3 projects to revert back to the last stable release in those situations. Hopefully this will allow for those listed Mill projects to still be tested in the community build.

This was originally reported on Discord but it looks like the
"unmanaged" community build is filtering out Mill projects that use
mill-tpolecat, as you can see in
https://github.com/VirtusLab/community-build3/blob/927f3751011d120c52a5217dfe8ccd3321f49c42/env/prod/config/filtered-projects.txt#L66-L69.
From the comment and from playing around it looks to be because if you
have a NIGHTLY or RC or anything it will puke. This adds a fallback for
Scala 3 projects to revert back to the last stable release in those
situations. Hopefully this will allow for those listed Mill projects to
still be tested in the community build.
@carlosedp
Copy link

carlosedp commented Oct 28, 2022

Awesome, thanks @ckipp01, will keep an eye here to ask them to remove project from filter once merged.

@joan38 joan38 merged commit 6feeecf into DavidGregory084:main Jan 11, 2023
@ckipp01 ckipp01 deleted the nightly branch January 11, 2023 15:06
@ckipp01
Copy link
Contributor Author

ckipp01 commented Jan 11, 2023

@joan38 thank you! Feel free to ping me when you cut a new release and I'll see if I can remove those repos from the community build and update those repos usages.

@joan38
Copy link
Collaborator

joan38 commented Jan 11, 2023

Thanks @ckipp01.
0.3.2 on it's way

@carlosedp
Copy link

Thanks Chris and Joan, I bumped the libs on riscvassembler and published v1.7.1 to address this (should be up in a couple mins).

@carlosedp
Copy link

@ckipp01 once the other two repos bump, would you open the PR removing from the filtered-projects or do you want me to do it?
Again, thanks for looking into this!

@ckipp01
Copy link
Contributor Author

ckipp01 commented Jan 11, 2023

@ckipp01 once the other two repos bump, would you open the PR removing from the filtered-projects or do you want me to do it? Again, thanks for looking into this!

Once they are bumped and released I can do it. But if you notice that's done and I haven't done it yet, feel free!

@carlosedp
Copy link

carlosedp commented Mar 21, 2023

Hi @ckipp01, since the other two projects haven't merged the PRs, I've sent a PR to remove my lib from the filters.
VirtusLab/community-build3#126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants