Added Ambient light #105

Sjack-Sch · 2020-08-12T19:58:52Z

With major support of @GrumpyMeow

With major support of Meow

custom_components/home_connect_beta/api.py

DavidMStraub · 2020-08-13T08:06:14Z

custom_components/home_connect_beta/light.py

            _LOGGER.debug("Tried to change brightness for: %s", self.name)
-            """Convert Home Assistant brightness (0-255) to Home Connect brightness (10-100)"""
+            """ Convert Home Assistant brightness (0-255) to Home Connect brightness (10-100)"""


This space should be removed; also there is no full stop. Please run pydocstyle and make sure it is happy.

Done, forgot to make pydocstyle happy :-)

Hi David,

Sorry to react so late, I totally forgot this PR.
Can we finish this PR?
After it has been merged I will merge it in the official HA.

Hi,

hmm strange, I also forgot about it. So is it ready to merge and all issues have been resolved?

Yep, al request have been resolved.
I am not sure if the 5 minute delays mentioned by @anthonyangel is still there. I will try this week to execute some tests to find out.

Hi Anthonie, thanks for sharing.
Would it be possible for you to check if the core version of home connect has a different delay?

OK great, let me know.

Also a heads-up: we should wait with the core PR until DavidMStraub/homeconnect#3 is finally closed (I just pushed a possible fix but have to wait for others testing it.).

I just checked the core version of home connect and I noticed the same delay before entities become available after a restart as seen in the beta version.

I think we can this PR.

Merge, you mean? 😉

Yep merge, auto correct is not always helping 🙃

By the way, I just got a mini-PR merged into HA core fixing the SSE reconnection issue by simply bumping the homeconnect dependency. I wanted to separate this from the feature PR as it is an important fix. @Sjack-Sch if you want feel free to open a PR at core with the additional changes in this repo.

anthonyangel · 2020-08-13T22:03:18Z

This takes 5+ minutes to startup, I tested this with appliance in standby / off state, and also turned everything on and checked and it was the same result. Potentially having the appliance which the programs can't be fetched for in the logs would help troubleshoot this further.

DEBUG (SyncWorker_1) [custom_components.home_connect_beta.api] Unable to fetch active programs. Probably offline.
WARNING (MainThread) [homeassistant.bootstrap] Waiting on integrations to complete setup: home_connect_beta

After a few minutes more I get:

2020-08-13 22:48:25 WARNING (MainThread) [homeassistant.bootstrap] Setup timed out for stage 2 - moving forward
2020-08-13 22:48:25 DEBUG (MainThread) [homeassistant.bootstrap] Waiting for startup to wrap up
2020-08-13 22:48:25 WARNING (MainThread) [homeassistant.bootstrap] Waiting on integrations to complete setup: home_connect_beta

And then eventually:

2020-08-13 22:48:26 INFO (MainThread) [homeassistant.bootstrap] Home Assistant initialized in 315.39s

The functionality for a hood works as intended (including colour & brightness), but when I try to set the ambient light on a dishwasher I get the following error. I'd assume that this ambient light only has on/off states and doesn't support brightness

2020-08-13 22:49:52 ERROR (MainThread) [custom_components.home_connect_beta.light] Error while trying selecting customcolor: {'key': 'SDK.Error.UnsupportedSetting', 'description': 'Setting is not supported'}
2020-08-13 22:49:52 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection.140337398648592] unsupported operand type(s) for /: 'NoneType' and 'int'
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 125, in handle_call_service
    await hass.services.async_call(
  File "/usr/src/homeassistant/homeassistant/core.py", line 1308, in async_call
    task.result()
  File "/usr/src/homeassistant/homeassistant/core.py", line 1343, in _execute_service
    await handler.func(service_call)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 208, in handle_service
    await self.hass.helpers.service.entity_service_call(
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 454, in entity_service_call
    future.result()  # pop exception if have
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 583, in async_request_call
    await coro
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 485, in _handle_entity_call
    await result
  File "/usr/src/homeassistant/homeassistant/components/light/__init__.py", line 249, in async_handle_light_on_service
    await light.async_turn_on(**params)
  File "/config/custom_components/home_connect_beta/light.py", line 103, in async_turn_on
    brightness = 10 + ceil(self._brightness / 255 * 90)
TypeError: unsupported operand type(s) for /: 'NoneType' and 'int'

DavidMStraub · 2020-08-14T08:05:05Z

This looks like it's due to the change requested above. During the (async) setup process, a sync call to the API is started which fails.

Sjack-Sch · 2020-08-14T15:29:10Z

This looks like it's due to the change requested above. During the (async) setup process, a sync call to the API is started which fails.

Hi @anthonyangel, I removed the sync call.
And added a check on Ambient brightness not set to None before converting from home assistant brightness to home connect brightness.

Could you please test the latest commits?

Brightness set to none for Ambient gave an error when converting from home assistant brightness to home connect brightness

anthonyangel · 2020-08-21T10:00:56Z

I checked the latest version of the code, I still get the slow startup for this component.

I also checked the dishwasher ambient light and I now get a different error:

2020-08-21 10:58:40 ERROR (MainThread) [custom_components.home_connect_beta.light] Error while trying to turn on light: {'key': 'SDK.Error.UnsupportedSetting', 'description': 'Setting is not supported'}

Sjack-Sch · 2020-08-21T16:54:06Z

I checked the latest version of the code, I still get the slow startup for this component.

I also checked the dishwasher ambient light and I now get a different error:
2020-08-21 10:58:40 ERROR (MainThread) [custom_components.home_connect_beta.light] Error while trying to turn on light: {'key': 'SDK.Error.UnsupportedSetting', 'description': 'Setting is not supported'}

Hi @anthonyangel,

It seems that your dishwasher does support ambient lighting.
Can you try /homeappliances/{haid}/settings in https://apiclient.home-connect.com for your dishwasher and share the response?

added the word "ambient" to the error notification for ambient light on

anthonyangel · 2020-08-21T17:20:19Z

When it's of off I get

{ "data": { "settings": [ { "key": "BSH.Common.Setting.PowerState", "value": "BSH.Common.EnumType.PowerState.Off", "name": "Power status", "displayvalue": "Off" } ] } }

When the power is on I get the same, but the API reports that the power status is on.

It must be one of those settings which is available in the app, but not the API. From my point of view it's not worth worrying about as it's a pretty useless feature (I only brought it up as it was discovered as an entity so I tested it)

Sjack-Sch · 2020-08-21T18:44:59Z

When it's of off I get
{ "data": { "settings": [ { "key": "BSH.Common.Setting.PowerState", "value": "BSH.Common.EnumType.PowerState.Off", "name": "Power status", "displayvalue": "Off" } ] } }
When the power is on I get the same, but the API reports that the power status is on.

It must be one of those settings which is available in the app, but not the API. From my point of view it's not worth worrying about as it's a pretty useless feature (I only brought it up as it was discovered as an entity so I tested it)

OK thanks, yep it seams that the ambient setting is not available/supported. Maybe Bosch will add this API in the future.
Does your Hood still work as expected?

GrumpyMeow · 2020-11-15T21:34:58Z

I've just cloned your "DavidMStraub:master' branch and mapped it into my Home Assistant.
The Ambient-light works perfectly on my Hood (LC97FVW60S).
I did had to do a restart of Home Assistant to have the entities to show up.

allmoney · 2020-12-01T10:23:04Z

When Functional Light of Hood will be available in HA integration?

DavidMStraub · 2020-12-02T16:22:41Z

Good question, "somebody" has to do a pull request. It is very low on my prio list because I don't have a hood light. Happy if someone volunteers.

Sjack-Sch · 2020-12-02T21:28:32Z

I will start a PR that adds functional and ambient lighting to the core soon.

allmoney · 2020-12-02T21:49:45Z

I will start a PR that adds functional and ambient lighting to the core soon.

Thank you so much !!! 👍

Sjack-Sch · 2020-12-09T21:26:42Z

A PR to HA core has been started:
Home connect functional and ambient light added #44091

Add Ambient light

f6108b8

With major support of Meow

Sjack-Sch mentioned this pull request Aug 12, 2020

added light brightness support #100

Merged

DavidMStraub suggested changes Aug 13, 2020

View reviewed changes

Removed fetch settings during initialization

85d4347

Update light.py

6876570

Brightness set to none for Ambient gave an error when converting from home assistant brightness to home connect brightness

Sjack-Sch mentioned this pull request Aug 19, 2020

Feature request: Implement hood controls under the fan domain #80

Open

Update light.py

81dfcb5

added the word "ambient" to the error notification for ambient light on

Sjack-Sch requested a review from DavidMStraub August 21, 2020 18:46

DavidMStraub merged commit fbfde3d into DavidMStraub:master Oct 17, 2020

anthonyangel mentioned this pull request Dec 1, 2020

Turn on/off the functional light of the hood #118

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Ambient light #105

Added Ambient light #105

Sjack-Sch commented Aug 12, 2020 •

edited

Loading

DavidMStraub Aug 13, 2020

Sjack-Sch Aug 13, 2020

Sjack-Sch Oct 6, 2020

DavidMStraub Oct 6, 2020

Sjack-Sch Oct 6, 2020

Sjack-Sch Oct 6, 2020

Sjack-Sch Oct 14, 2020 •

edited

Loading

DavidMStraub Oct 17, 2020

Sjack-Sch Oct 17, 2020

DavidMStraub Oct 18, 2020

anthonyangel commented Aug 13, 2020

DavidMStraub commented Aug 14, 2020

Sjack-Sch commented Aug 14, 2020 •

edited

Loading

anthonyangel commented Aug 21, 2020

Sjack-Sch commented Aug 21, 2020

anthonyangel commented Aug 21, 2020

Sjack-Sch commented Aug 21, 2020

GrumpyMeow commented Nov 15, 2020

allmoney commented Dec 1, 2020

DavidMStraub commented Dec 2, 2020

Sjack-Sch commented Dec 2, 2020

allmoney commented Dec 2, 2020

Sjack-Sch commented Dec 9, 2020

Added Ambient light #105

Added Ambient light #105

Conversation

Sjack-Sch commented Aug 12, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sjack-Sch Oct 14, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anthonyangel commented Aug 13, 2020

DavidMStraub commented Aug 14, 2020

Sjack-Sch commented Aug 14, 2020 • edited Loading

anthonyangel commented Aug 21, 2020

Sjack-Sch commented Aug 21, 2020

anthonyangel commented Aug 21, 2020

Sjack-Sch commented Aug 21, 2020

GrumpyMeow commented Nov 15, 2020

allmoney commented Dec 1, 2020

DavidMStraub commented Dec 2, 2020

Sjack-Sch commented Dec 2, 2020

allmoney commented Dec 2, 2020

Sjack-Sch commented Dec 9, 2020

Sjack-Sch commented Aug 12, 2020 •

edited

Loading

Sjack-Sch Oct 14, 2020 •

edited

Loading

Sjack-Sch commented Aug 14, 2020 •

edited

Loading