Fix for Rails 3 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks much! Unfortunately this fix breaks the plugin in Rails 2.3, but I can easily enough just have the plugin choose which version of the filter method to employ based on the rails version. Also, I think I'm going to be making this plugin into a gem pretty soon (plugins are so old-school nowadays!), so keep an eye out for that. |
|
All my latest projects have been Rails 3 so I didn't even think of backwards compatibility. Bad, Pat, bad. Everyone loves gems now. Thanks, Bundler! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I found your plugin b/c I was growing oh so sick and tired of SQLite printing that stupid line multiple times. But it didn't work for Rails 3.0.7. So I fixed it.
Thank you for doing the leg work on the original plugin. You've saved my eyes. :)
Pat