Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to current modules #3

Closed
dasher opened this issue May 2, 2015 · 5 comments
Closed

Update to current modules #3

dasher opened this issue May 2, 2015 · 5 comments

Comments

@dasher
Copy link
Contributor

dasher commented May 2, 2015

You can pull and merge dasher@a3646f7 to bring the app up to the current module versions.

I'll generate a proper pull request a little later.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/12857567-update-to-current-modules?utm_campaign=plugin&utm_content=tracker%2F6823236&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F6823236&utm_medium=issues&utm_source=github).
@dasher
Copy link
Contributor Author

dasher commented May 2, 2015

I'm happy to do some cleanup on the project, remove some duplication and refactor the server side code to make it a little cleaner.

Lemme know if you're happy with these types of changes.

@DavidStodolsky
Copy link
Owner

Did you generate a proper pull request?

@dasher dasher mentioned this issue May 5, 2015
@dasher
Copy link
Contributor Author

dasher commented May 5, 2015

Pull request should now be visible - should be a clean merge

Next steps - I was thinking of:
reworking api.js as server.js to remove duplication
add tests
cleanup the messageDispatcher to the latest spec of socket.io

@DavidStodolsky
Copy link
Owner

I'm happy to do some cleanup on the project, remove some duplication and refactor the server side code to make it a little cleaner.

I am trying to avoid looking at code as much as possible. If you can remove duplication, etc. to make the code easier to deal with and less likely to have bugs, fine.

By the way, you ought to subscribe to the mailing list so you get project news and can ask any questions you may have:
Mturn@googlegroups.com

@dasher
Copy link
Contributor Author

dasher commented May 6, 2015

subscribed.
I'll setup a server for you to access the current code - would you send an email to dasher@crucialdivide.com and once it's up I'll email you access details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants