Fixed an issue with parsing an empty port.

DavidTPate · Aug 19, 2014 · f132a0f · f132a0f
1 parent 9808555
commit f132a0f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -1,5 +1,5 @@
 var simplePathPattern = /^(\/?[a-z0-9-._~!$&'()*+,;=:@%\/]+)(\?([a-z0-9!$&'()*+-,;=:\[\]@\/\?%]+)?)?(#[a-z0-9!$&'()*+,;=:#-\[\]@\/\?%]+)?$/i,
-    giantPattern = /^([a-z0-9\.\+-]+:)?\/\/(([a-z0-9!$&'()*+-,;=#\[\]@\/\?%]+:[a-z0-9!$&'()*+-,;=#\[\]@\/\?%]+)@)?([a-z0-9\-\._]+)(:([0-9]+))?(\/([a-z0-9-._~!$&'()*+,;=:@%\/]+)?)?(\?[a-z0-9!$&'()*+-,;=:\[\]@\/\?%]+)?(#[a-z0-9!$&'()*+,;=:#-\[\]@\/\?%]+)?$/i,
+    giantPattern = /^([a-z0-9\.\+-]+:)?\/\/(([a-z0-9!$&'()*+-,;=#\[\]@\/\?%]+:[a-z0-9!$&'()*+-,;=#\[\]@\/\?%]+)@)?([a-z0-9\-\._]+)(:([0-9]+)?)?(\/([a-z0-9-._~!$&'()*+,;=:@%\/]+)?)?(\?[a-z0-9!$&'()*+-,;=:\[\]@\/\?%]+)?(#[a-z0-9!$&'()*+,;=:#-\[\]@\/\?%]+)?$/i,
     protocolPattern = /^[a-z0-9\.\+-]+:/i,
     queryStringPartPattern = /\??([^\?\=\&]+)\=?([^\=\&]+)?/g;
 

diff --git a/test/test-node.js b/test/test-node.js
@@ -244,7 +244,7 @@ describe('Node.js URL Tests', function () {
         (!!!parsed.hash).should.be.true;
         parsed.href.should.be.exactly('www.example.com');
     });
-    it.skip('should parse an absolute URL with an empty port', function () {
+    it('should parse an absolute URL with an empty port', function () {
         var parsed = decomposeUrl.parse('http://example.com:');
 
         parsed.protocol.should.be.exactly('http:');