Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build-project): accidentally overwriting options #29

Merged
merged 3 commits into from
Feb 15, 2023

Conversation

DavidVujic
Copy link
Owner

Description

The build-project command unintentionally had overwritten the poetry build command options.

Also, a typo in how the new with-top-namespace option was picked up.

Motivation and Context

Fixes #28

How Has This Been Tested?

Installed a new version with the code in this Pull Request.

Ran build-project with, and without, the -f flag, in combination with the with-top-namespace flag.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@DavidVujic DavidVujic merged commit 23ba589 into main Feb 15, 2023
@DavidVujic DavidVujic deleted the fix_project_build_options branch February 15, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing -f option in 1.2
1 participant