-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow paths for top namespace #34
Allow paths for top namespace #34
Conversation
…sing the flag git push
I was really struggling to figure out how to better test this so mistakes like I made in #32 don't happen again.
That is so very cumbersome to setup, but not the end of the world. Curious if there is a better way for another PR. |
Thank you @ryaminal, I'll have a look! |
We started using a project published with these changes and it appears to be working. Apologies again for the wasted time with my mistakes. |
Great, thank you @ryaminal! ⭐ I will have a look this weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 👏 👏
v1.30 is out! Thank you for contributing to this project! |
Description
Adding the forward slash
/
to the filter for top-namespace when normalizingMotivation and Context
We would like to create a top level with something like
foo/bar
so that the module can be imported asimport foo.bar.stuff
.How Has This Been Tested?
Tested this locally on my mac. Should work on most *nix systems, but I'm not certain how it will impact Windows.
Made sure to have files that actually import with the top-namespace.
Types of changes
Checklist: