Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build-project): rewrite script entries when using custom top namespace #50

Merged
merged 6 commits into from
Mar 6, 2024

Conversation

DavidVujic
Copy link
Owner

@DavidVujic DavidVujic commented Mar 5, 2024

Description

Rewrite the entries in [tool.poetry.scripts] with a top namespace, when passing in the --with-custom-namespace option for poetry build-project.

Motivation and Context

Requested in DavidVujic/python-polylith#178

This will make the build-project more flexible and not assume that the custom top namespace have been added manually in the pyproject.toml file for a CLI script entry.

How Has This Been Tested?

✅ CI
✅ Added unit tests for the TOML generation.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DavidVujic DavidVujic changed the title wip(build-project): rewrite script entries when using custom top namespace feat(build-project): rewrite script entries when using custom top namespace Mar 6, 2024
@DavidVujic DavidVujic marked this pull request as ready for review March 6, 2024 12:22
@DavidVujic DavidVujic merged commit 5ba524a into main Mar 6, 2024
3 checks passed
@DavidVujic DavidVujic deleted the custom-top-ns-rewrite-script-entries branch March 6, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant