Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poly check caps comparison #108

Merged
merged 5 commits into from
Sep 9, 2023
Merged

Poly check caps comparison #108

merged 5 commits into from
Sep 9, 2023

Conversation

DavidVujic
Copy link
Owner

Description

Fixing an issue with the third-party dependency check, caused by not taking casing into account when finding close matches.

An example:
The pillow library. When importing it, using from PIL .... This has failed, even if the similarities between the two should match.

This PR will compare the registered dependencies with the unknown imports in a case-insensitive way.

Motivation and Context

Fixing #107

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DavidVujic DavidVujic merged commit 7a178f6 into main Sep 9, 2023
4 checks passed
@DavidVujic DavidVujic deleted the poly-check-caps-comparison branch September 9, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant