Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified namespaces #3

Merged
merged 3 commits into from
Apr 22, 2016
Merged

Simplified namespaces #3

merged 3 commits into from
Apr 22, 2016

Conversation

gadiener
Copy link
Contributor

I think less is more ✌️

@DavidePastore
Copy link
Owner

It could be ok for me, but I don't know if it's well to directly own the CodiceFiscale namespace. In this way it's simpler to use (or to import) but it can cause name collision if there are other package with the same namespace.
What do you think?

@gadiener
Copy link
Contributor Author

I think it's a very rare case to find a package with the namespace "CodiceFiscale" and doing a little research I haven't found anyone.

@DavidePastore
Copy link
Owner

👍 Can you also edit README.md to accordingly edit the documentation and remove the DavidePastore directories?

@gadiener
Copy link
Contributor Author

👍 😉

@DavidePastore DavidePastore merged commit 353f5c2 into DavidePastore:master Apr 22, 2016
@DavidePastore
Copy link
Owner

Thanks for the PR 👍

@gadiener
Copy link
Contributor Author

😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gadiener @DavidePastore