Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculator name normalization #60

Merged

Conversation

francescolaffi
Copy link

fix #54 (and some other edge cases)

For what I was able to understand from official source, and verify with very limited real cases, only a specific subset of characters with accents or diacritics are transliterated.

eg: Ž is considered as Z, but ñ is not whitelested so is ignored

Refs:

@DavidePastore
Copy link
Owner

Hi @francescolaffi. Thanks for this PR! Unfortunately it seems that the PHP 7.2 build is broken. Could you take a look at it? Thanks!

@francescolaffi
Copy link
Author

Looks like I stumbled in some behaviour change between php 7.2 and 7.3 for casing of the sharp s. all other chars are handled consistently: https://3v4l.org/p9WAL

handled both the lower and upper sharp s to the char array as php < 7.3 consider them different characters and not differnt casing of the same character

@francescolaffi
Copy link
Author

@DavidePastore hi Davide, if you could trigger the workflow meanwhile we can see if its green on all php versions, thanks!

@DavidePastore DavidePastore merged commit 41b89ea into DavidePastore:master Mar 19, 2022
@DavidePastore
Copy link
Owner

Thanks for your effort on this PR, @francescolaffi. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with non italian characters in name and surname
3 participants