Add missing rules #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the logic needed to invalidate a tip if we find an invalid block or the user decides to.
Miners can only spend a coinbase transaction after a certain number of confirmations. This commit verifies that, using the utreexo commitment to this utxo height.
Davidson-Souza
force-pushed
the
add_missing_rules
branch
from
1aa0461
to
774d6f7
Compare
Until now, we validate with VERIFY_ALL, meaning we assume all soft-forks are always enabled, but for mainnet and testnet, this isn't true. This commit adds the activation height for buried soft-forks and only enforces them after this block.
Davidson-Souza
force-pushed
the
add_missing_rules
branch
from
774d6f7
to
9f52017
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR we check: