Skip to content

Commit

Permalink
Merge branch 'feature/rails-6.1'
Browse files Browse the repository at this point in the history
* feature/rails-6.1:
  Add Rails 6.1 compatibility
  • Loading branch information
tagliala committed Nov 3, 2020
2 parents b0171ac + 445ebd5 commit b6476c8
Show file tree
Hide file tree
Showing 15 changed files with 42 additions and 35 deletions.
2 changes: 1 addition & 1 deletion .rubocop.yml
Expand Up @@ -7,7 +7,7 @@ AllCops:
TargetRubyVersion: 2.4
NewCops: enable
Exclude:
- 'gemfiles/vendor/bundle/**/*'
- 'gemfiles/**/*'
- 'node_modules/**/*'
- 'vendor/bundle/**/*'

Expand Down
3 changes: 3 additions & 0 deletions .travis.yml
Expand Up @@ -17,6 +17,7 @@ gemfile:
- gemfiles/rails_5.1.gemfile
- gemfiles/rails_5.2.gemfile
- gemfiles/rails_6.0.gemfile
- gemfiles/rails_6.1.gemfile
- gemfiles/rails_edge.gemfile

cache:
Expand All @@ -39,6 +40,8 @@ jobs:
- rvm: ruby-head
- gemfile: gemfiles/rails_edge.gemfile
exclude:
- rvm: 2.4.10
gemfile: gemfiles/rails_6.1.gemfile
- rvm: 2.4.10
gemfile: gemfiles/rails_6.0.gemfile
- rvm: 2.4.10
Expand Down
4 changes: 4 additions & 0 deletions Appraisals
Expand Up @@ -18,6 +18,10 @@ appraise 'rails-6.0' do
gem 'rails', '~> 6.0.0'
end

appraise 'rails-6.1' do
gem 'rails', '~> 6.1.0.rc1'
end

appraise 'rails-edge' do
gem 'rails', github: 'rails/rails'
end
5 changes: 5 additions & 0 deletions CHANGELOG.md
@@ -1,5 +1,10 @@
# Changelog

## 17.2.0 / 2020-11-03

* [FEATURE] Add Rails 6.1.0.rc1 compatibility
* [ENHANCEMENT] Update development dependencies

## 17.1.1 / 2020-10-31

* [ENHANCEMENT] Minor code cleanup
Expand Down
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -8,7 +8,7 @@
[![Coverage Status](https://coveralls.io/repos/github/DavyJonesLocker/client_side_validations/badge.svg?branch=master)](https://coveralls.io/github/DavyJonesLocker/client_side_validations?branch=master)


`ClientSideValidations` made easy for your Rails 5.x / Rails 6.0 applications!
`ClientSideValidations` made easy for your Rails 5.x / Rails 6.x applications!

## Project Goals ##

Expand Down
2 changes: 1 addition & 1 deletion client_side_validations.gemspec
Expand Up @@ -25,7 +25,7 @@ Gem::Specification.new do |spec|
spec.platform = Gem::Platform::RUBY
spec.required_ruby_version = '>= 2.4'

spec.add_dependency 'rails', '>= 5.0.0.1', '< 6.1'
spec.add_dependency 'rails', '>= 5.0.0.1', '< 6.2'

spec.add_dependency 'js_regex', '~> 3.1'

Expand Down
10 changes: 4 additions & 6 deletions gemfiles/rails_5.0.gemfile
@@ -1,10 +1,8 @@
# frozen_string_literal: true

# This file was generated by Appraisal

source 'https://rubygems.org'
source "https://rubygems.org"

gem 'rails', '~> 5.0.0'
gem 'sqlite3', '~> 1.3.6'
gem "rails", "~> 5.0.0"
gem "sqlite3", "~> 1.3.6"

gemspec path: '../'
gemspec path: "../"
10 changes: 4 additions & 6 deletions gemfiles/rails_5.1.gemfile
@@ -1,10 +1,8 @@
# frozen_string_literal: true

# This file was generated by Appraisal

source 'https://rubygems.org'
source "https://rubygems.org"

gem 'rails', '~> 5.1.0'
gem 'sqlite3', '~> 1.3.6'
gem "rails", "~> 5.1.0"
gem "sqlite3", "~> 1.3.6"

gemspec path: '../'
gemspec path: "../"
8 changes: 3 additions & 5 deletions gemfiles/rails_5.2.gemfile
@@ -1,9 +1,7 @@
# frozen_string_literal: true

# This file was generated by Appraisal

source 'https://rubygems.org'
source "https://rubygems.org"

gem 'rails', '~> 5.2.0'
gem "rails", "~> 5.2.0"

gemspec path: '../'
gemspec path: "../"
8 changes: 3 additions & 5 deletions gemfiles/rails_6.0.gemfile
@@ -1,9 +1,7 @@
# frozen_string_literal: true

# This file was generated by Appraisal

source 'https://rubygems.org'
source "https://rubygems.org"

gem 'rails', '~> 6.0.0'
gem "rails", "~> 6.0.0"

gemspec path: '../'
gemspec path: "../"
7 changes: 7 additions & 0 deletions gemfiles/rails_6.1.gemfile
@@ -0,0 +1,7 @@
# This file was generated by Appraisal

source "https://rubygems.org"

gem "rails", "~> 6.1.0.rc1"

gemspec path: "../"
8 changes: 3 additions & 5 deletions gemfiles/rails_edge.gemfile
@@ -1,9 +1,7 @@
# frozen_string_literal: true

# This file was generated by Appraisal

source 'https://rubygems.org'
source "https://rubygems.org"

gem 'rails', github: 'rails/rails'
gem "rails", github: "rails/rails"

gemspec path: '../'
gemspec path: "../"
2 changes: 1 addition & 1 deletion lib/client_side_validations/version.rb
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module ClientSideValidations
VERSION = '17.1.1'
VERSION = '17.2.0'
end
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -28,7 +28,7 @@
"@rollup/plugin-node-resolve": "^10.0.0",
"chrome-launcher": "^0.13.4",
"puppeteer-core": "^5.4.1",
"rollup": "^2.32.1",
"rollup": "^2.33.1",
"rollup-plugin-copy": "^3.3.0",
"standard": "^16.0.1"
},
Expand Down
4 changes: 1 addition & 3 deletions test/action_view/cases/helper.rb
Expand Up @@ -224,8 +224,6 @@ def csv_data_attribute(validators)
}.to_json
end

protected

def comments_path(post)
"/posts/#{post.id}/comments"
end
Expand All @@ -246,7 +244,7 @@ def admin_comment_path(post, comment)
end
alias admin_post_comment_path admin_comment_path

def posts_path(_options = {})
def posts_path(*)
'/posts'
end

Expand Down

0 comments on commit b6476c8

Please sign in to comment.