Application Defined Messages Not Being Used

[gyarra]

Hi,

I'm using Rails 3.0.5 and client_side_validations 3.0.5. I'm seeing the default Rails error message displayed instead of my custom error messages.

Code:

 validates :address1, :length => {:minimum => 5, :message => "Address must be at least 5 characters"} 

When the address1 field fails client-side validation, the default message "is too short..." displays instead of my defined message "Address must be ...". If I submit the form so the page reloads with errors, the error I specified is correctly displayed next to the field. But as soon as I modify the field and validation fails again, the default error is again rendered.

Please let me know if this is expected behavior. If not I'll dig deeper.

Thanks,
Gabe

[gyarra]

OK, dug a little deeper. I'm thinking this is caused by a translation issue. Possibly.

On line 14 of client_side_validations/active_model/length.rb

from the console, I run:

adr.errors.generate_message(:address1, :minimum, 3) ```

Which generates:
 => "translation missing: en.activerecord.errors.models.address.attributes.address1.minimum"

Not totally sure that the parameters are correct in the method call, but I played around with a bunch.  I'm not really sure why the message would be translated.  generate_message looks at I18n, but I would think since there's nothing there, it would return the initial message ...

[gyarra]

OK, figured out a fix, but I think it's still a bug. At least it's not the behavior I'd expect.

If I specify the error message in en.yml it's picked up by client_side_validations. So the gem is ignoring messages defined as options in the validation methods themselves and instead looking in the localization file, even though I'm not using I18n. This is a different behavior from the validation in the Rails code, which picks up the :message option.

If this is the expected behavior it should probably be documented in the wiki. If not, I'm happy to look into a fix.

Also, I don't want to seem too critical. This gem is great and I'm very happy with it. Thanks for making it!

[bcardarella]

Yes, this is a bug. Thank-you. Sorry it took so long for me to get to it.