Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors in IE8, caused by usage of 'indexOf()' #498

Closed
toao opened this issue Mar 5, 2013 · 1 comment
Closed

Errors in IE8, caused by usage of 'indexOf()' #498

toao opened this issue Mar 5, 2013 · 1 comment

Comments

@toao
Copy link

toao commented Mar 5, 2013

The commit ec0a0fb introduced a bug for IE8 (and possibly lower) because indexOf() is used in https://github.com/bcardarella/client_side_validations/blob/3-2-stable/coffeescript/rails.validations.coffee#L405.

Microsoft added support for indexOf() initially in IE9 :/
@bcardarella
Copy link
Contributor

We don't support IE8, sorry

@maintux maintux mentioned this issue Mar 6, 2013
Closed
gmcnaughton pushed a commit to curious/client_side_validations that referenced this issue Mar 26, 2013
Fixes DavyJonesLocker#498 and DavyJonesLocker#499 (IE8 incompatibilit…
e113d80 
…y). Changes Array.indexOf call to use coffeescript's 'x in Array' construct.
@gmcnaughton gmcnaughton mentioned this issue Mar 26, 2013
Merged
bcardarella added a commit that referenced this issue Mar 26, 2013
@bcardarella
Merge pull request #511 from kartofflly/fix-ie8-incompatibility
c1b8561 
Fixes #498 and #499 (IE8 incompatibility)
@tagliala tagliala mentioned this issue Apr 10, 2013
Closed
@sigmike sigmike mentioned this issue Jun 20, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcardarella @toao