-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise on missing translations causes issues in Rails 7.1 #920
Labels
Comments
tagliala
added a commit
that referenced
this issue
Oct 8, 2023
When `config.i18n.raise_on_missing_translations` is enabled, Rails 7.1 raises on missing translation error when validation messages are not translated, which is a new behavior causing CSV to fail For unsupported validations, like `comparison`, and custom validations, like `timeliness`, CSV attempts to create a message for a key that is not present. This commit standardizes the behavior and fallbacks on "invalid" when a translation is not found, which is supposed to be the desired behavior for this use case Close #920
tagliala
added a commit
that referenced
this issue
Oct 8, 2023
When `config.i18n.raise_on_missing_translations` is enabled, Rails 7.1 raises on missing translation error when validation messages are not translated, which is a new behavior causing CSV to fail For unsupported validations, like `comparison`, and custom validations, like `timeliness`, CSV attempts to create a message for a key that is not present. This commit standardizes the behavior and fallbacks on "invalid" when a translation is not found, which is supposed to be the desired behavior for this use case Close #920
tagliala
added a commit
that referenced
this issue
Oct 8, 2023
When `config.i18n.raise_on_missing_translations` is enabled, Rails 7.1 raises on missing translation error when validation messages are not translated, which is a new behavior causing CSV to fail For unsupported validations, like `comparison`, and custom validations, like `timeliness`, CSV attempts to create a message for a key that is not present. This commit standardizes the behavior and fallbacks on "invalid" when a translation is not found, which is supposed to be the desired behavior for this use case Close #920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When
config.i18n.raise_on_missing_translations
is enabled, Rails 7.1 raises on missing translations also when a translation is not found in a validation error message. This did not happen in 7.0For some custom validations, like
timeliness
, client side validations attempts to create a message for "timeliness" error, which is not present.On Rails 7.0 this did not fail, and the output would have contained a missing translation error
Steps to reproduce*
validates :leave_date, timeliness: { on_or_after: -> { Time.current } }
)Expected behavior*
Does not fail
Actual behavior*
System configuration*
Rails version: 7.1
Ruby version: 3.2.2
Client Side Validations version: main
Code snippet from your model of the validations*
The whole form code from your template*
The resulting HTML*
not needed
Browser's development console output*
Additional JavaScript Libraries*
does not apply
Repository demostrating the issue
https://github.com/diowa/icare/tree/feature/rails-71
The text was updated successfully, but these errors were encountered: