Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump puppeteer-core from 3.3.0 to 4.0.0 #796

Merged
merged 1 commit into from Jun 16, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps puppeteer-core from 3.3.0 to 4.0.0.

Release notes

Sourced from puppeteer-core's releases.

v4.0.0

Breaking change: Puppeteer no longer uses Node’s EventEmitter library

As part of our work to make Puppeteer agnostic of its environment we are removing the dependency on Node’s EventEmitter in favour of an event emitter that is not tied to Node. Under the hood we use Mitt, but we extend Mitt with additional functionality to match most of the methods that Node’s EventEmitter provides. The following methods have been removed from Puppeteer classes that extend EventEmitter:

  • eventNames()
  • getMaxListeners()
  • listeners(eventName)
  • prependListener
  • prependOnceListener
  • setMaxListeners(n)
  • rawListeners(eventName)

Additionally all the static methods on the EventEmitter class are not supported:

  • listenerCount(emitter, eventName)
  • defaultMaxListeners
  • errorMonitor

Node’s EventEmitter emitted a newListener event when a listener was added and a removeListener event when one was removed. These are not supported and will not be emitted.

New features and improvements

  • Send/receive debug logs are now split out into separate channels making the logs much clearer (#6017)
  • You can now call isJavaScriptEnabled() on a Puppeteer page to find out if JS is enabled on the page (#5993)

Bug fixes

  • Puppeteer is now much better at killing lingering browser processes, especially when you exit a test run with Ctrl-C (#6011)

Behind the scenes

  • We've started work on a new documentation system that uses TSDoc to generate documentation from our source code and have been porting documentation into code accordingly.

Raw notes

5493494 - chore: mark version 4.0.0 03ab1c1 - fix: improve Ctrl + C support (#6011) b659969 - chore: migrate away from Node's EventEmitter (#5979) 6e060ce - fix(connection): separate send/receive debug logging (#6017) c701ea1 - chore: fix npm test command (#6010) 398c16d - chore: fix docs linter (#6009) 4205ff7 - docs(api): remove subheader for non-namespace 3d56a9e - chore: add test configuration options for running tests against multiple products (#5964) 5c91dfb - chore: move index.js into src (#6007) 8a099a0 - docs: replace @return with @returns (#6006) 23f18d8 - docs(new): start documenting the Page class (#6001) c1d7be3 - docs(api): add copy-pasting text example to Mouse class (#6000) 91eb745 - chore: ensure new-docs are up to date (#5994) b86ff21 - feat(api): add Page.isJavaScriptEnabled + mark properties as private (#5993)

... (truncated)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [puppeteer-core](https://github.com/puppeteer/puppeteer) from 3.3.0 to 4.0.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Commits](puppeteer/puppeteer@v3.3.0...v4.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file javascript labels Jun 16, 2020
@coveralls
Copy link

coveralls commented Jun 16, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling ee5efe4 on dependabot/npm_and_yarn/puppeteer-core-4.0.0 into 1707027 on master.

@tagliala tagliala merged commit 092312a into master Jun 16, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/puppeteer-core-4.0.0 branch June 16, 2020 08:15
@tagliala
Copy link
Contributor

Failures on rails edge: rails/rails#39152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants