Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Dependent Objects #144

Merged
merged 2 commits into from May 28, 2019

Conversation

Projects
None yet
2 participants
@DaveStabilify
Copy link
Contributor

commented Feb 1, 2019

Adding context menu options to generate a query to display dependencies for the selected object from the metadata pane.

Dave Harland
@dgosbell

This comment has been minimized.

Copy link
Contributor

commented Feb 3, 2019

This looks good. There are probably a couple of small tweaks we need to make.

Both the TreeViewTable and TreeViewColumn classes implement the IADOTabularObject interface. I've started working on exposing a Name and ObjectType property through this interface. We would need to swap over to using Name instead of Caption as the Caption property can change if the model has translations, while the Name is the how the object is referred to internally.

I'd also like to look at maybe altering the WHERE clause to filter on REFERENCED_TABLE for tables and REFERENCED_OBJECT for columns/measures.

Finally I think I can possibly extend the SendTextToEditor event so that it can also trigger the execution of this query, which would be a nice enhancement.

Update MetadataPaneViewModel.cs
Corrected class name referenced in Log.Error of catch.
@DaveStabilify

This comment has been minimized.

Copy link
Contributor Author

commented Feb 3, 2019

This looks good. There are probably a couple of small tweaks we need to make.

Both the TreeViewTable and TreeViewColumn classes implement the IADOTabularObject interface. I've started working on exposing a Name and ObjectType property through this interface. We would need to swap over to using Name instead of Caption as the Caption property can change if the model has translations, while the Name is the how the object is referred to internally.

I'd also like to look at maybe altering the WHERE clause to filter on REFERENCED_TABLE for tables and REFERENCED_OBJECT for columns/measures.

Finally I think I can possibly extend the SendTextToEditor event so that it can also trigger the execution of this query, which would be a nice enhancement.

Sounds good. I wasn't too concerned about triggering the execution of the query because the other context menu options don't behave that way but it's up to you. Also, I just pushed a minor fix to the MetadataPaneViewModel class.

@dgosbell

This comment has been minimized.

Copy link
Contributor

commented Feb 4, 2019

Yes, the query execution is just a "nice to have", but we don't currently have any other features that generate a fully executable query. The current features all inject definitions into existing queries and the expectation is that often the user may want to do some performance tuning on these definitions before running them.

@DaveStabilify

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2019

That's a good point.

@dgosbell dgosbell merged commit e69e9e4 into DaxStudio:develop May 28, 2019

2 checks passed

DaxStudio.DaxStudio Build #20190203.4 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.