Enable programmatically opening or closing panel #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mainej 👍 and apologies for the delay in getting to this. |
|
@superstructor we'll need something added to the docs so that others are aware of this new feature. Plus something in the changelog |
kimo-k
added a commit
that referenced
this pull request
Jun 16, 2023
kimo-k
added a commit
that referenced
this pull request
Jun 18, 2023
kimo-k
added a commit
that referenced
this pull request
Jun 18, 2023
kimo-k
added a commit
that referenced
this pull request
Jun 18, 2023
kimo-k
added a commit
that referenced
this pull request
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To hide the panel, run
(day8.re-frame-10x/show-panel! false)from ClojureScript, orday8.re_frame_10x.trace.show_panel_BANG_(false)in the JavaScript console. To show the panel, passtrueinstead.This would satisfy #181. It might also help some use cases in #204.
I prefer dispatching
:settings/show-panel?over:settings/user-toggle-panelbecause it's idempotent. You have to first check the current state of the panel to know what will happen with:settings/user-toggle-panel. Let me know, though, if you'd prefer to keep:settings/show-panel?internal.