Skip to content

Commit

Permalink
Fix upload artfacts.
Browse files Browse the repository at this point in the history
  • Loading branch information
Daylily-Zeleen committed Jul 30, 2023
1 parent 667c06d commit 68d004a
Show file tree
Hide file tree
Showing 12 changed files with 82 additions and 17 deletions.
4 changes: 2 additions & 2 deletions .github/actions/build/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ runs:
SCONS_CACHE: .scons-cache
SCONS_CACHE_DIR: .scons-cache
run: |
cd godot-cpp && scons target=${{ inputs.target }} platform=${{ inputs.platform }} arch=${{ inputs.arch }} generate_bindings=yes ${{ inputs.sconsflags }}
cd godot-cpp && scons target=${{ inputs.target }} platform=${{ inputs.platform }} arch=${{ inputs.arch }} generate_bindings=yes ${{ inputs.sconsflags }} optimize=speed
- name: Build Godot Universal Serializer 2
shell: sh
env:
SCONS_CACHE: .scons-cache
SCONS_CACHE_DIR: .scons-cache
run: |
scons target=${{ inputs.target }} platform=${{ inputs.platform }} arch=${{ inputs.arch }} generate_bindings=no ${{ inputs.sconsflags }}
scons target=${{ inputs.target }} platform=${{ inputs.platform }} arch=${{ inputs.arch }} generate_bindings=no ${{ inputs.sconsflags }} optimize=speed
8 changes: 7 additions & 1 deletion .github/actions/upload/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,16 @@ description: Upload Godot Cpp and the Godot Universal Serializer 2 Extension.
runs:
using: composite
steps:
- name: Copy dynamic library to dist dir.
shell: sh
if: ${{ inputs.platform != 'macos' }}
run: |
cp -r bin/libgus2.${{ inputs.artifact_file_suffix }} dist/addons/com.daylily_zeleen.godot_universal_serializer2/bin/libgus2.${{ inputs.artifact_file_suffix }}
- name: Upload Artifact
uses: actions/upload-artifact@v3
with:
name: Godot Universal Serializer 2
path: |
${{ github.workspace }}/dist/addons/com.daylily_zeleen.godot_universal_serializer2/bin/libgus2.${{ inputs.artifact_file_suffix }}
${{ github.workspace }}/dist/**
retention-days: 14
3 changes: 2 additions & 1 deletion .github/workflows/android_builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
matrix:
target: [template_debug, template_release]
arch: [arm64, x86_64]
shlibsuffix: ["so"]
shlibsuffix: [so]

steps:
- uses: actions/checkout@v3
Expand All @@ -38,4 +38,5 @@ jobs:
- name: Upload ${{ matrix.target }} ${{ matrix.arch }}
uses: ./.github/actions/upload
with:
platform: android
artifact_file_suffix: android.${{ matrix.target }}.${{ matrix.arch }}.${{ matrix.shlibsuffix }}
3 changes: 2 additions & 1 deletion .github/workflows/ios_builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
matrix:
target: [template_debug, template_release]
arch: [arm64]
shlibsuffix: ["dylib"]
shlibsuffix: [dylib]

steps:
- uses: actions/checkout@v3
Expand All @@ -32,4 +32,5 @@ jobs:
- name: Upload ${{ matrix.target }} ${{ matrix.arch }}
uses: ./.github/actions/upload
with:
platform: ios
artifact_file_suffix: ios.${{ matrix.target }}.${{ matrix.arch }}.${{ matrix.shlibsuffix }}
5 changes: 3 additions & 2 deletions .github/workflows/linux_builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ jobs:
fail-fast: false
matrix:
target: [template_debug, template_release]
arch: [x86_64]
shlibsuffix: ["so"]
arch: [x86_64, arm64, rv64 ]
shlibsuffix: [so]

steps:
- uses: actions/checkout@v3
Expand All @@ -33,5 +33,6 @@ jobs:
- name: Upload ${{ matrix.target }} ${{ matrix.arch }}
uses: ./.github/actions/upload
with:
platform: linux
artifact_file_suffix: linux.${{ matrix.target }}.${{ matrix.arch }}.${{ matrix.shlibsuffix }}

7 changes: 4 additions & 3 deletions .github/workflows/macos_builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
matrix:
target: [template_debug, template_release]
arch: [universal]
shlibsuffix: ["framework"]
shlibsuffix: [dylib]

steps:
- uses: actions/checkout@v3
Expand All @@ -40,10 +40,11 @@ jobs:
APPLE_DEV_TEAM_ID: ${{ secrets.PROD_MACOS_NOTARIZATION_TEAM_ID }}
APPLE_DEV_PASSWORD: ${{ secrets.PROD_MACOS_NOTARIZATION_PWD }}
APPLE_DEV_APP_ID: ${{ secrets.PROD_MACOS_APPLE_DEV_APP_ID }}
run: ./misc/ci-sign-macos.ps1 dist/addons/com.daylily_zeleen.godot_universal_serializer2/bin/libgus2.macos.${{ matrix.target }}.framework
run: ./misc/ci-sign-macos.ps1 dist/addons/com.daylily_zeleen.godot_universal_serializer2/libgus2.macos.${{ matrix.target }}.framework
if: ${{ env.APPLE_DEV_ID }}

- name: Upload ${{ matrix.target }} ${{ matrix.arch }}
uses: ./.github/actions/upload
with:
artifact_file_suffix: macos.${{ matrix.target }}.${{ matrix.arch }}.${{ matrix.shlibsuffix }}
platform: macos
artifact_file_suffix: macos.${{ matrix.target }}.${{ matrix.arch }}.${{ matrix.shlibsuffix }}/
1 change: 1 addition & 0 deletions .github/workflows/web_builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,6 @@ jobs:
- name: Upload ${{ matrix.target }} ${{ matrix.arch }}
uses: ./.github/actions/upload
with:
platform: javascript
artifact_file_suffix: javascript.${{ matrix.target }}.${{ matrix.arch }}.${{ matrix.shlibsuffix }}

3 changes: 2 additions & 1 deletion .github/workflows/windows_builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
matrix:
target: [template_debug, template_release]
arch: [x86_32, x86_64]
shlibsuffix: ["dll"]
shlibsuffix: [dll]

steps:
- uses: actions/checkout@v3
Expand All @@ -35,4 +35,5 @@ jobs:
- name: Upload ${{ matrix.target }} ${{ matrix.arch }}
uses: ./.github/actions/upload
with:
platform: windows
artifact_file_suffix: windows.${{ matrix.target }}.${{ matrix.arch }}.${{ matrix.shlibsuffix }}
7 changes: 2 additions & 5 deletions SConstruct
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,16 @@ sources = Glob("src/*.cpp")
# env["CXXFLAGS"] = ["-std=c++2a"]


bin_dir = "dist/addons/com.daylily_zeleen.godot_universal_serializer2/bin/"

if env["platform"] == "macos":
library = env.SharedLibrary(
bin_dir
+ "libgus2.{}.{}.framework/libguss.{}.{}".format(
"dist/addons/com.daylily_zeleen.godot_universal_serializer2/bin/libgus2.{}.{}.framework/libguss.{}.{}".format(
env["platform"], env["target"], env["platform"], env["target"]
),
source=sources,
)
else:
library = env.SharedLibrary(
bin_dir + "libgus2{}{}".format(env["suffix"], env["SHLIBSUFFIX"]),
"bin/libgus2{}{}".format(env["suffix"], env["SHLIBSUFFIX"]),
source=sources,
)

Expand Down
2 changes: 1 addition & 1 deletion build.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def main():
if arg.startswith("target"):
debug_and_relaese = False

bin_dir = "dist/addons/com.daylily_zeleen.godot_universal_serializer2/bin/"
bin_dir = "bin/" #"dist/addons/com.daylily_zeleen.godot_universal_serializer2/bin/"
# Remove all last build files.
for f in os.listdir(bin_dir):
os.remove(path_join(bin_dir, f))
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>CFBundleExecutable</key>
<string>libgus2.macos.template_debug</string>
<key>CFBundleIdentifier</key>
<string>org.godot-universal-serializer2.godot-universal-serializer2</string>
<key>CFBundleInfoDictionaryVersion</key>
<string>6.0</string>
<key>CFBundleName</key>
<string>Godot Box2D</string>
<key>CFBundlePackageType</key>
<string>FMWK</string>
<key>CFBundleShortVersionString</key>
<string>1.0.0</string>
<key>CFBundleSupportedPlatforms</key>
<array>
<string>MacOSX</string>
</array>
<key>NSHumanReadableCopyright</key>
<string>Copyright (c) 2022-present Ricardo Buring and Dragos Daian.</string>
<key>CFBundleVersion</key>
<string>1.0.0</string>
<key>LSMinimumSystemVersion</key>
<string>10.12</string>
</dict>
</plist>
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>CFBundleExecutable</key>
<string>libgus2.macos.template_release</string>
<key>CFBundleIdentifier</key>
<string>org.godot-universal-serializer2.godot-universal-serializer2</string>
<key>CFBundleInfoDictionaryVersion</key>
<string>6.0</string>
<key>CFBundleName</key>
<string>Godot Box2D</string>
<key>CFBundlePackageType</key>
<string>FMWK</string>
<key>CFBundleShortVersionString</key>
<string>1.0.0</string>
<key>CFBundleSupportedPlatforms</key>
<array>
<string>MacOSX</string>
</array>
<key>NSHumanReadableCopyright</key>
<string>Copyright (c) 2022-present Ricardo Buring and Dragos Daian.</string>
<key>CFBundleVersion</key>
<string>1.0.0</string>
<key>LSMinimumSystemVersion</key>
<string>10.12</string>
</dict>
</plist>

0 comments on commit 68d004a

Please sign in to comment.