-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: logs are now timestamped, their level is written. #21
base: master
Are you sure you want to change the base?
Conversation
- The logs previously only included in debug version are now in the release version too. - The performance log explaining how many skeletons are active are now verbose instead of debug.
FYI, the first word in a commit should be a verb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure SKSE doesn't have the ability to add time stamps through a format string? It seems odd to have to manually do it in our own class.
I don't see anything in their logging code about this. Maybe they didn't want to have to manage the related perf and multi-threading challenges? |
Argh... Thank you. |
po3 logs have timestamps. I'll have to go look how he did it. |
My understanding is that he didn't use the SKSE logging system, but reimplemented it with stdlog: |
His way is better than mine, because he lets stdlog handle the time retrieval and the related multi-threading challenges. |
the release version too.
now verbose instead of debug.