Merge pull request #41 from BeryJu/fix-panic

fix panics when API calls fail
DazWilkin · Feb 24, 2024 · 8a9d5c9 · 8a9d5c9
2 parents 6921867 + c4e6c43
commit 8a9d5c9
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 0 deletions.
diff --git a/collector/account.go b/collector/account.go
@@ -47,6 +47,7 @@ func (c *AccountCollector) Collect(ch chan<- prometheus.Metric) {
 	account, err := c.client.GetAccount(ctx)
 	if err != nil {
 		log.Println(err)
+		return
 	}
 
 	ch <- prometheus.MustNewConstMetric(

diff --git a/collector/instance.go b/collector/instance.go
@@ -65,6 +65,7 @@ func (c *InstanceCollector) Collect(ch chan<- prometheus.Metric) {
 	instances, err := c.client.ListInstances(ctx, nil)
 	if err != nil {
 		log.Println(err)
+		return
 	}
 	log.Printf("[InstaneCollector:Collect] len(instances)=%d", len(instances))
 

diff --git a/collector/instance_stats.go b/collector/instance_stats.go
@@ -63,6 +63,7 @@ func (c *InstanceStatsCollector) Collect(ch chan<- prometheus.Metric) {
 	instances, err := c.client.ListInstances(ctx, nil)
 	if err != nil {
 		log.Println(err)
+		return
 	}
 	log.Printf("[InstanceStatsCollector:Collect] len(instances)=%d", len(instances))
 

diff --git a/collector/kubernetes.go b/collector/kubernetes.go
@@ -55,6 +55,7 @@ func (c *KubernetesCollector) Collect(ch chan<- prometheus.Metric) {
 	clusters, err := c.client.ListLKEClusters(ctx, nil)
 	if err != nil {
 		log.Println(err)
+		return
 	}
 	log.Printf("[KubernetesCollector:Collect] len(clusters)=%d", len(clusters))
 
@@ -73,6 +74,7 @@ func (c *KubernetesCollector) Collect(ch chan<- prometheus.Metric) {
 			pools, err := c.client.ListLKEClusterPools(ctx, k.ID, nil)
 			if err != nil {
 				log.Println(err)
+				return
 			}
 			log.Printf("[KubernetesCollector:Collect] Cluster: %d len(nodepools)=%d", k.ID, len(pools))
 

diff --git a/collector/nodebalancer.go b/collector/nodebalancer.go
@@ -63,6 +63,7 @@ func (c *NodeBalancerCollector) Collect(ch chan<- prometheus.Metric) {
 	nodebalancers, err := c.client.ListNodeBalancers(ctx, nil)
 	if err != nil {
 		log.Println(err)
+		return
 	}
 	log.Printf("[NodeBalancerCollector:Collect] len(nodebalancers)=%d", len(nodebalancers))
 

diff --git a/collector/ticket.go b/collector/ticket.go
@@ -41,6 +41,7 @@ func (c *TicketCollector) Collect(ch chan<- prometheus.Metric) {
 	tickets, err := c.client.ListTickets(ctx, nil)
 	if err != nil {
 		log.Println(err)
+		return
 	}
 
 	total := make(map[linodego.TicketStatus]float64)

diff --git a/collector/volume.go b/collector/volume.go
@@ -41,6 +41,7 @@ func (c *VolumeCollector) Collect(ch chan<- prometheus.Metric) {
 	volumes, err := c.client.ListVolumes(ctx, nil)
 	if err != nil {
 		log.Println(err)
+		return
 	}
 	log.Printf("[VolumeCollector:Collect] len(volumes)=%d", len(volumes))