Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing error for attribute error & adding 0.G Gaiman installation information. #86

Merged
merged 3 commits into from
Mar 13, 2023

Conversation

Leonlit
Copy link

@Leonlit Leonlit commented Mar 5, 2023

I encountered this error during the installation process for 0.G Gaiman. This error is the same error found in #84 .

Type: <class 'sqlalchemy.exc.ArgumentError'>
Value: Strings are not accepted for attribute names in loader options; please use class-bound attributes directly.
Traceback:
  File "C:\Users\leon\Desktop\CDDA-Game-Launcher\cddagl\ui\views\main.py", line 1167, in timeout
    new_build(self.game_version, sha256, is_stable, self.build_number,
  File "C:\Users\leon\Desktop\CDDA-Game-Launcher\cddagl\sql\functions.py", line 136, in new_build
    .options(joinedload('game_build'))
  File "C:\Users\leon\Desktop\CDDA-Game-Launcher\venv\lib\site-packages\sqlalchemy\orm\strategy_options.py", line 2359, in joinedload
    return _generate_from_keys(Load.joinedload, keys, False, kw)
  File "C:\Users\leon\Desktop\CDDA-Game-Launcher\venv\lib\site-packages\sqlalchemy\orm\strategy_options.py", line 2261, in _generate_from_keys
    raise sa_exc.ArgumentError(

The cause was by the 'joinedload' function in the 'cddagl/sql/functions.py' file. As a workaround, I used the attribute directly from the class.

image

DazedNConfused- and others added 3 commits January 23, 2023 13:17
 - Fixed error caused by the joinedload function in 'cddagl/sql/functions.py' by using the class attribute 'game_build' directly from 'GameVersion' class.
 - Adding game installation info for 0.G Gaiman.
@DazedNConfused-
Copy link
Owner

Howdy @Leonlit! I will get this out ASAP. Thanks a ton for your PR!

@DazedNConfused- DazedNConfused- merged commit 697b4b4 into DazedNConfused-:develop Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants