Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in edge layer to adapt palyload to proper contract #19

Closed
ralphg6 opened this issue Jan 24, 2020 · 3 comments · Fixed by #36
Closed

Add in edge layer to adapt palyload to proper contract #19

ralphg6 opened this issue Jan 24, 2020 · 3 comments · Fixed by #36
Assignees
Labels
enhancement New feature or request
Projects
Milestone

Comments

@ralphg6
Copy link
Collaborator

ralphg6 commented Jan 24, 2020

The main idea is to support API payloads of any platforms. By example:

For input in Watson's API payload format:

POST http://localhost:5005/dialog?_if=watson

If the input format isn't explicitly informed, maybe we can build a component that tries to resolve the format.

Also maybe we can implement support to output format, but only if will be needed.

@arthurTemporim arthurTemporim added this to Backlog in David Jan 29, 2020
@ralphg6 ralphg6 moved this from Backlog to Doing in David Feb 4, 2020
@ralphg6 ralphg6 added the enhancement New feature or request label Feb 4, 2020
@ralphg6 ralphg6 self-assigned this Feb 4, 2020
@ralphg6
Copy link
Collaborator Author

ralphg6 commented Feb 4, 2020

I'm working in this functionality in branch: issue/19-edge-adapter

@ralphg6
Copy link
Collaborator Author

ralphg6 commented Feb 4, 2020

During the development, I realized that not have a sense parametrize a different format in input and output.
So I implemented the support for 'adapter' query param that defines the format of input payload and output payload.

The usage is:

http://localhost:5000/dialog?adapter=watson

Where "watson" is the name of the adapter.

Until the moment, only "message" adapter is working. And he is the default adapter.

I will close this issue and create two new to develop the Watson adapter and to create a config for change default adapter of running instance.

@ralphg6 ralphg6 closed this as completed Feb 4, 2020
@ralphg6 ralphg6 reopened this Feb 4, 2020
@ralphg6
Copy link
Collaborator Author

ralphg6 commented Feb 4, 2020

Hehe, we have to merge before close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
David
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant