Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the creation process of a new adapter #37

Open
ralphg6 opened this issue Feb 4, 2020 · 0 comments
Open

Document the creation process of a new adapter #37

ralphg6 opened this issue Feb 4, 2020 · 0 comments
Labels
documentation
Projects
David

Comments

@ralphg6
Copy link
Collaborator

ralphg6 commented Feb 4, 2020

In issue #19, we created a layer to adapt the dialog API for the desired format.

Now we able to build adapters for any formats compatible with Message object.

https://github.com/ralphg6/david/blob/bfb535c21f9bf7720e58d99653334972958e03f9/david/typing/message.py#L11

To build a new adapter is needs to implement the class Adapter.

https://github.com/ralphg6/david/blob/bfb535c21f9bf7720e58d99653334972958e03f9/david/adapters/adapter.py#L7-L21

As I built the MessageAdapter:

https://github.com/ralphg6/david/blob/bfb535c21f9bf7720e58d99653334972958e03f9/david/adapters/adapter.py#L24-L36
This was referenced Feb 4, 2020
Open
Open
Closed
@ralphg6 ralphg6 added this to the 1.1.0 milestone Feb 5, 2020
@ralphg6 ralphg6 added this to Backlog in David Feb 5, 2020
@ralphg6 ralphg6 removed the good first issue Good for newcomers label Feb 6, 2020
@ralphg6 ralphg6 removed this from the 1.1.0 milestone Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
David
  
Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ralphg6