Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a way to config the running instance #42

Closed
ralphg6 opened this issue Feb 4, 2020 · 1 comment · Fixed by #62
Closed

Build a way to config the running instance #42

ralphg6 opened this issue Feb 4, 2020 · 1 comment · Fixed by #62
Assignees
Labels
architecture enhancement New feature or request
Projects
Milestone

Comments

@ralphg6
Copy link
Collaborator

ralphg6 commented Feb 4, 2020

I think that we will able to configure two ways.

By config file and by CLI arguments. Being that CLI args prevail over the config file.

The configs must be easily available in all the project code.

@ralphg6 ralphg6 added architecture enhancement New feature or request labels Feb 4, 2020
@ralphg6 ralphg6 added this to the 0.0.1-alpha milestone Feb 5, 2020
@ralphg6 ralphg6 added this to Backlog in David Feb 5, 2020
@ralphg6 ralphg6 moved this from Backlog to To do in David Feb 5, 2020
@ralphg6 ralphg6 self-assigned this Feb 5, 2020
ralphg6 added a commit that referenced this issue Feb 5, 2020
@ralphg6
Copy link
Collaborator Author

ralphg6 commented Feb 5, 2020

Part of implementation was added in #52

ralphg6 added a commit that referenced this issue Feb 5, 2020
* Implement JSON Reader #49 #48

* Include suport the config file #42

* Json reader as module

* Adjust format
@ralphg6 ralphg6 moved this from To do to Doing in David Feb 5, 2020
@ralphg6 ralphg6 moved this from Doing to To do in David Feb 5, 2020
@ralphg6 ralphg6 moved this from To do to Doing in David Feb 5, 2020
@ralphg6 ralphg6 moved this from Doing to To do in David Feb 6, 2020
@ralphg6 ralphg6 mentioned this issue Feb 11, 2020
David automation moved this from To do to Done Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture enhancement New feature or request
Projects
David
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant