Feat - Add should-lint-lockfile input to control the linting of the lockfile
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrChocolatine
force-pushed
the
allow-to-disable-lockfile-lint
branch
from
6253ba7
to
28df059
Compare
MrChocolatine
added a commit
to DazzlingFugu/ember-reading-time
that referenced
this pull request
Feb 24, 2024
Fore more details see: DazzlingFugu/.github#2
MrChocolatine
changed the title
should-lint-lockfile input to control lockfile lintshould-lint-lockfile input to control the linting of the lockfile
BlueCutOfficial
approved these changes
Mar 4, 2024
BlueCutOfficial
pushed a commit
to DazzlingFugu/ember-reading-time
that referenced
this pull request
Mar 11, 2024
Fore more details see: DazzlingFugu/.github#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers
Once you have reviewed this PR, please review the following one as well:
DazzlingFugu/ember-reading-time#171
Feat
Add
should-lint-lockfileinput to control the linting of the lockfile (#2)We currently have an issue in
ember-reading-timewhere all pipelines fail, which is caused by the version of Node.js (v14) we use and it is not supported anymore due to a recent change in the source code of the Github Actionlockfile-lint.Error we are having:
https://github.com/DazzlingFugu/ember-reading-time/actions/runs/7937277494/job/21683383771?pr=166
Node.js v14 being used in
ember-reading-time:https://github.com/DazzlingFugu/ember-reading-time/actions/runs/8026155957/workflow
https://github.com/DazzlingFugu/ember-reading-time/blob/d5e881dfff33cb3ce438a2e108631f01437744d1/.github/workflows/ci.yml
I made an attempt to use Node.js v16 instead, it appears to fix the error but we get different errors: (another problem to solve later)
https://github.com/DazzlingFugu/ember-reading-time/actions/runs/8030366522/job/21937683314
The error comes from these lines:
https://github.com/lirantal/lockfile-lint/blob/5278050700971f18a59114c362bc234836d24f14/packages/lockfile-lint-api/src/ParseLockfile.js#L34-L35
that were updated here:
lirantal/lockfile-lint@217f67d#diff-3ce6d2c32203200a2f67ec457643b02f015d2b60fa87fd5e6f6bea3f2c35007f