Skip to content

Commit

Permalink
refactor: fix lint issues
Browse files Browse the repository at this point in the history
  • Loading branch information
MrChocolatine committed May 21, 2021
1 parent 9505c3d commit 18b4f24
Show file tree
Hide file tree
Showing 10 changed files with 33 additions and 36 deletions.
8 changes: 3 additions & 5 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
'use strict'
'use strict';

module.exports = {
root: true,
Expand All @@ -10,9 +10,7 @@ module.exports = {
legacyDecorators: true,
},
},
plugins: [
'ember'
],
plugins: ['ember'],
extends: [
'eslint:recommended',
'plugin:ember/recommended',
Expand Down Expand Up @@ -53,4 +51,4 @@ module.exports = {
extends: ['plugin:node/recommended'],
},
],
}
};
4 changes: 2 additions & 2 deletions .template-lintrc.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict'
'use strict';

module.exports = {
extends: 'octane',
}
};
2 changes: 1 addition & 1 deletion app/initializers/embedded.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export { default, initialize } from 'ember-cli-embedded/initializers/embedded'
export { default, initialize } from 'ember-cli-embedded/initializers/embedded';
5 changes: 4 additions & 1 deletion app/instance-initializers/embedded.js
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
export { default, initialize } from 'ember-cli-embedded/instance-initializers/embedded'
export {
default,
initialize,
} from 'ember-cli-embedded/instance-initializers/embedded';
2 changes: 1 addition & 1 deletion app/services/embedded.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export { default } from 'ember-cli-embedded/services/embedded'
export { default } from 'ember-cli-embedded/services/embedded';
12 changes: 6 additions & 6 deletions config/ember-try.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'
'use strict';

const getChannelURL = require('ember-source-channel-url')
const getChannelURL = require('ember-source-channel-url');

module.exports = async function () {
return {
Expand Down Expand Up @@ -53,8 +53,8 @@ module.exports = async function () {
{
name: 'ember-default',
npm: {
devDependencies: {}
}
devDependencies: {},
},
},
{
name: 'ember-default-with-jquery',
Expand Down Expand Up @@ -85,5 +85,5 @@ module.exports = async function () {
},
},
],
}
}
};
};
6 changes: 3 additions & 3 deletions config/environment.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict'
'use strict';

module.exports = function (/* environment, appConfig */) {
return {}
}
return {};
};
10 changes: 5 additions & 5 deletions ember-cli-build.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
'use strict'
'use strict';

const EmberAddon = require('ember-cli/lib/broccoli/ember-addon')
const EmberAddon = require('ember-cli/lib/broccoli/ember-addon');

module.exports = function (defaults) {
let app = new EmberAddon(defaults, {
// Add options here
})
});

/*
This build file specifies the options for the dummy test app of this
Expand All @@ -14,5 +14,5 @@ module.exports = function (defaults) {
behave. You most likely want to be modifying `./index.js` or app's build file
*/

return app.toTree()
}
return app.toTree();
};
8 changes: 4 additions & 4 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
'use strict'
'use strict';

module.exports = {
name: require('./package').name,

config: function (_env, config) {
if (!config.embedded || !this.app) {
return
return;
}

// As the app will be embedded, we should not make any assumptions
// regarding the execution context (aka index.html) and therefore
// (try to) make sure that the app can be deployed to any page,
// therefore move the config anywhere but in the meta tag.
this.app.options.storeConfigInMeta = false
this.app.options.storeConfigInMeta = false;
},

options: {
babel: {
sourceMaps: 'inline',
},
},
}
};
12 changes: 4 additions & 8 deletions testem.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
'use strict'
'use strict';

module.exports = {
test_page: 'tests/index.html?hidepassed',
disable_watching: true,
launch_in_ci: [
'Chrome'
],
launch_in_dev: [
'Chrome'
],
launch_in_ci: ['Chrome'],
launch_in_dev: ['Chrome'],
browser_start_timeout: 120,
browser_args: {
Chrome: {
Expand All @@ -24,4 +20,4 @@ module.exports = {
].filter(Boolean),
},
},
}
};

0 comments on commit 18b4f24

Please sign in to comment.