Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update ember-try config, add embroider test scenarios #121

Merged
merged 4 commits into from
Sep 7, 2021

Conversation

yonmey
Copy link
Contributor

@yonmey yonmey commented Aug 27, 2021

CI

Update ember-try scenarios with Ember 3.24 LTS and Embroider tests (#121)

Remove ember- prefix from Github Actions config

Remove Ember 3.16 LTS from ember-try testing

Remove ember-canary scenario

Add Ember 3.24 LTS to ember-try testing

Add @embroider/test-setup to ember-try

This update adds the embroider-safe and embroider-optimized scenarios to ember-try. This gives the opportunity to check whether the addon is ready for Embroider or not.
@embroider/test-setup

@MrChocolatine
Copy link
Member

@yonmey , testing against Ember.js beta and canary has been removed in #122 .

@yonmey yonmey force-pushed the build/replace-ember-try-ember-versions branch from 7145c21 to b840bda Compare September 6, 2021 08:25
Copy link
Member

@MrChocolatine MrChocolatine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have *.orig files do we want to keep them? These files also have git-diff syntax in them <<<<<<< HEAD, I am not sure we want to keep that.

Is the PR finished 🤔 ?

Also, why removing the prefix ember- from the test scenarios? It does not seem to bring any value here, also I thought it would be easier to have scenarios with a full name alongside Embroider scenarios named embroider-*.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@yonmey
Copy link
Contributor Author

yonmey commented Sep 7, 2021

We still have *.orig files do we want to keep them? These files also have git-diff syntax in them <<<<<<< HEAD, I am not sure we want to keep that.
Is the PR finished 🤔 ?

This has been a mistake, I have commit some files coming from the Idea mergetool, I didn't notice it. Fixed.

Also, why removing the prefix ember- from the test scenarios? It does not seem to bring any value here, also I thought it would be easier to have scenarios with a full name alongside Embroider scenarios named embroider-*.

I removed the ember- prefix so that we have an homogeneous wording in all our projects, the Embroider config doesn't add this prefix.

- Add `@embroider/test-setup` package and config
- Remove Canary scenario from `ember-try`
- Remove `ember-` prefix from ember-try configuration
- Update Ember LTS versions in `ember-try`
@yonmey yonmey force-pushed the build/replace-ember-try-ember-versions branch from 9358e78 to fa252a1 Compare September 7, 2021 08:09
@MrChocolatine
Copy link
Member

I removed the ember- prefix so that we have an homogeneous wording in all our projects, the Embroider config doesn't add this prefix.

I see, I initially thought we wanted full names.

@yonmey yonmey merged commit 8ea85e6 into master Sep 7, 2021
@yonmey yonmey deleted the build/replace-ember-try-ember-versions branch September 7, 2021 08:26
@MrChocolatine MrChocolatine mentioned this pull request Sep 10, 2021
@MrChocolatine MrChocolatine added the ci Continuous Integration label Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants