fix: bind application to start function
#188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ember-try scenarios |
ndekeister-us
approved these changes
Jun 27, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Bind
applicationtostartfunction (#188)Attempt to fix #186.
Fix successfully tested against a fresh Ember.js app in version
4.4.0.Tests suite successfully ran against Node.js v12, v14 and v16.
Chore
Turn off
noEmitOnErrorrule (#188)Temporarily disable
noEmitOnErrorTS rule to unblock ember-try scenarios in the CI, to be turned on when we manage to fix type errors in this repo for ember-try scenarios.