Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade ember-cli-typescript to v5.1.0 #195

Merged
merged 13 commits into from
Aug 14, 2022

Conversation

ndekeister-us
Copy link
Member

@ndekeister-us ndekeister-us commented Jun 27, 2022

Build

Upgrade ember-cli-typescript to v5.1.0 (#195)

Also

Chore

Run ember-cli-typescript blueprint (#195)

To be up to date with ember-cli-typescript config and recommandations in tsconfig.json

Running blueprints also add back @types/ember* packages in devDependencies, which solves a side effect introduced by #157.

  • If we remove some @types/ember* packages from our devDependencies, they will still be included by other packages but they will resolve to a version sometimes incompatible with other @types/ember__* packages, resulting of type errors in build
  • Keeping us sync with ember-cli-typescript ensure we don't face this issue again in this future

Example of build failing when we remove some @types/ember__x packages that we don't use (like routing, engine, array... ; even after a yarn-deduplicate && yarn):
Capture d’écran 2022-06-27 à 23 31 56

Run yarn-deduplicate && yarn (#195)

Fix build and test by resolving @types/ember* packages to one single version in the yarn.lock (otherwise we would have sometimes two different versions for some @types/ember* packages, which would leads to type conflicts when building app

@ndekeister-us ndekeister-us force-pushed the build/upgrade_ember-cli-typescript branch 2 times, most recently from 3ae18ab to f94c7bc Compare June 27, 2022 21:45
@ndekeister-us ndekeister-us marked this pull request as ready for review June 27, 2022 22:02
@ndekeister-us ndekeister-us requested a review from a team as a code owner June 27, 2022 22:02
@ndekeister-us ndekeister-us force-pushed the build/upgrade_ember-cli-typescript branch from f94c7bc to 6ee312f Compare July 1, 2022 13:21
@ndekeister-us ndekeister-us requested a review from a team as a code owner July 1, 2022 13:21
@MrChocolatine
Copy link
Member

MrChocolatine commented Jul 6, 2022

I wanted to take a look yesterday sorry, I will try this evening. (but I haven't forgotten, it is still in my todo-list)

Copy link
Member

@MrChocolatine MrChocolatine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments and suggestions, but overall seems good to me, thanks for taking the time 👍 .

I trust you on the changes related to the "types" packages, I tried to make the upgrade on my side too and too many different errors (the entire tests suite would sometimes pass, sometimes not, something telling me our Initializer could not be found...).

And if for some reason we actually need every @types packages for Ember.js (those automatically shipped with ember-cli-typescript) then why not, it's not a big deal in the end).

tsconfig.json Show resolved Hide resolved
tests/unit/services/embedded-test.ts Outdated Show resolved Hide resolved
tests/unit/services/embedded-test.ts Outdated Show resolved Hide resolved
addon/initializers/embedded.ts Outdated Show resolved Hide resolved
tests/unit/initializers/embedded-test.ts Outdated Show resolved Hide resolved
addon/instance-initializers/embedded.ts Show resolved Hide resolved
@MrChocolatine MrChocolatine added dependencies Changes that update a dependency file ts-types labels Jul 9, 2022
@ndekeister-us ndekeister-us force-pushed the build/upgrade_ember-cli-typescript branch from 20430bf to c291e9a Compare August 10, 2022 09:54
@MrChocolatine MrChocolatine force-pushed the build/upgrade_ember-cli-typescript branch from c291e9a to 43a731e Compare August 14, 2022 16:02
@MrChocolatine MrChocolatine force-pushed the build/upgrade_ember-cli-typescript branch from 43a731e to 8c9187a Compare August 14, 2022 16:04
@MrChocolatine MrChocolatine merged commit 90f3b45 into master Aug 14, 2022
@MrChocolatine MrChocolatine deleted the build/upgrade_ember-cli-typescript branch August 14, 2022 16:09
@spinelle spinelle mentioned this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants