Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: upgrade ember to v4.4 #196

Merged
merged 5 commits into from
Sep 3, 2022
Merged

build: upgrade ember to v4.4 #196

merged 5 commits into from
Sep 3, 2022

Conversation

ndekeister-us
Copy link
Member

@ndekeister-us ndekeister-us commented Jun 27, 2022 •
edited by BlueCutOfficial
Loading

Build

Upgrade to Ember 4 (#196)

  • Internal changes using ember-cli-update
  • Drop test for ember-default-with-jquery scenario (non breaking as the scenario was not launched by the CI).

@ndekeister-us ndekeister-us marked this pull request as ready for review September 2, 2022 13:13
@ndekeister-us ndekeister-us requested a review from a team as a code owner September 2, 2022 13:13
@ndekeister-us ndekeister-us added the dependencies Changes that update a dependency file label Sep 2, 2022
BlueCutOfficial
BlueCutOfficial reviewed Sep 2, 2022
View reviewed changes
Copy link
Member

@BlueCutOfficial BlueCutOfficial left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a "Merge" commit in your stack 🙀

.ember-cli Outdated Show resolved Hide resolved
.ember-cli Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@BlueCutOfficial BlueCutOfficial merged commit 63481b7 into master Sep 3, 2022
@BlueCutOfficial BlueCutOfficial deleted the chore/upgrade_ember-4 branch September 3, 2022 18:55
@MrChocolatine MrChocolatine added documentation ci Continuous Integration labels Sep 5, 2022
@MrChocolatine MrChocolatine changed the title chore: upgrade ember to v4.4 build: upgrade ember to v4.4 Sep 5, 2022
@spinelle spinelle mentioned this pull request May 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlueCutOfficial BlueCutOfficial BlueCutOfficial approved these changes

Assignees
No one assigned
Labels
ci Continuous Integration dependencies Changes that update a dependency file documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ndekeister-us @BlueCutOfficial @MrChocolatine