Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: drop node 12 support #228

Merged
merged 2 commits into from Nov 10, 2022
Merged

Conversation

ndekeister-us
Copy link
Member

@ndekeister-us ndekeister-us commented Oct 7, 2022

Breaking

Drop node 12 support (#228)

Build

Upgrade eslint-plugin-ember to v11 (#228)

@ndekeister-us ndekeister-us added the wait Wait before merging label Oct 7, 2022
@ndekeister-us
Copy link
Member Author

Not urgent at all, we can wait for other breaking changes before merging it, goal is to free a dependabot slot by replacing dependabot PRs updating dependencies which requiers Node >=14, like this one #221

@MrChocolatine MrChocolatine added dependencies Changes that update a dependency file breaking Breaking changes labels Nov 6, 2022
@MrChocolatine
Copy link
Member

@ndekeister-us
I rebased your branch, I will let you merge your PR and remove the label wait whenever you want.

@ndekeister-us ndekeister-us removed the wait Wait before merging label Nov 10, 2022
@ndekeister-us ndekeister-us merged commit 389e101 into master Nov 10, 2022
@ndekeister-us ndekeister-us deleted the breaking/drop_node-12_support branch November 10, 2022 15:38
@spinelle spinelle mentioned this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes dependencies Changes that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants