Refactor to Typescript #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcambar
force-pushed
the
typescript
branch
4 times, most recently
from
794d382
to
21d9f35
Compare
GreatWizard
reviewed
Jul 22, 2020
GreatWizard
force-pushed
the
typescript
branch
2 times, most recently
from
33884d0
to
c9dc6e6
Compare
GreatWizard
force-pushed
the
typescript
branch
from
c9dc6e6
to
9cbd038
Compare
|
I think we should also convert dummy and tests in this PR |
|
@GreatWizard We may in the future convert tests to TS, but the goal og this PR was to test compatibility of an addon in TS with a JS-based app. What do you think? |
GreatWizard
approved these changes
Aug 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done with the help of: