Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: updates to ember 5.3 - drops Ember 4.4 #2

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

Pixelik
Copy link
Collaborator

@Pixelik Pixelik commented Oct 11, 2023

Resolves adopted-ember-addons#733

Chore

Refactor

Breaking

  • drops support for Ember 4.4
    • because we only support the last 2 LTS version anyway & because the relevant Ember 4.4 test scenario throws Error: required module @ember/renderer is missing
  • drops support for Node v14

Tasks:

  • Added test case(s)
  • Updated documentation

- otherwise the ember-4.4-lts test scenario throws Error
…ent.filter

- because PromiseManyArray.filter no longer exists in Ember 5
- as it is no longer allowed on Ember 5
- otherwise the following tests sometimes fail:
- Integration | Validations | Factory - General: debounced validations
- Integration | Validations | Factory - General: debounced validator should only be called once
- otherwise relevant Ember 4.4 test scenario throws Error:
- required module @ember/renderer is missing
@Pixelik Pixelik self-assigned this Oct 11, 2023
@Pixelik Pixelik changed the title chore: updates to ember 5 3 breaking: updates to ember 5.3 - drops Ember 4.4 Oct 11, 2023
@Pixelik Pixelik force-pushed the chore/updates-to-ember-5-3 branch 3 times, most recently from 6533ee4 to a61c20f Compare October 11, 2023 15:13
- otherwise the embroider test scenarios throw Error:
- "EmberObject.create no longer supports defining computed properties"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant