Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate .../getting-started/anatomy-of-an-ember-app.md #164

Merged
merged 2 commits into from Mar 31, 2023
Merged

Translate .../getting-started/anatomy-of-an-ember-app.md #164

merged 2 commits into from Mar 31, 2023

Conversation

BlueCutOfficial
Copy link
Member

Closes #48

@BlueCutOfficial BlueCutOfficial force-pushed the translate-anatomy-of-an-ember-app branch from 7c76911 to 334d544 Compare March 15, 2023 15:37
@BlueCutOfficial BlueCutOfficial self-assigned this Mar 15, 2023
@BlueCutOfficial BlueCutOfficial added the Guides FR trad File from the Ember Guides to translate in French label Mar 15, 2023
@BlueCutOfficial BlueCutOfficial changed the title Feat: Translate .../getting-started/anatomy-of-an-ember-app.md Translate .../getting-started/anatomy-of-an-ember-app.md Mar 15, 2023
Agathebadia
Agathebadia reviewed Mar 25, 2023
View reviewed changes
Copy link
Collaborator

@Agathebadia Agathebadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 12 - cliquant - instead of clicquant
line 81 - alt='image de profil'

@BlueCutOfficial
Copy link
Member Author

@Agathebadia Thanks a lot for the review and for spotting these typos 🙏

A tiny tip that could save you some time: I recommend to left your comments directly on the concerned line with a suggestion syntax.

  • You can target one or several lines with the plus button
  • Then the "+/- file" icon represents a diff, clicking on it will generate for you a suggestion block that you can edit directly
  • If (for some reason) I don't want to consider 100% of your suggestion but only a part of it, I can perfectly answer your suggestion with a new one.

Capture d’écran 2023-03-30 à 17 56 58

🙏 Sorry if you already know all of this and you do not use suggestions on purpose. I know your company works on Bitbucket, that's why I thought you may not know that feature.

@Agathebadia
Copy link
Collaborator

Yes sorry for that, Github is weird atm with me, I could not add a proper review as usual, and added a comment here. Not sure if it's related to my token renewal :S

Agathebadia
Agathebadia approved these changes Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@Agathebadia Agathebadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BlueCutOfficial BlueCutOfficial merged commit 97d4612 into master Mar 31, 2023
2 checks passed
@BlueCutOfficial BlueCutOfficial deleted the translate-anatomy-of-an-ember-app branch March 31, 2023 13:18
@MrChocolatine
Copy link
Member

I know your company works on Bitbucket

pkm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Agathebadia Agathebadia Agathebadia approved these changes

@GreatWizard GreatWizard Awaiting requested review from GreatWizard

@KamiKillertO KamiKillertO Awaiting requested review from KamiKillertO

@MrChocolatine MrChocolatine Awaiting requested review from MrChocolatine

@romgere romgere Awaiting requested review from romgere

Assignees

@BlueCutOfficial BlueCutOfficial

Labels
Guides FR trad File from the Ember Guides to translate in French
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate /getting-started/anatomy-of-an-ember-app.md, Ember 4.7
3 participants
@BlueCutOfficial @Agathebadia @MrChocolatine