Fix for #188 Table '<schemaversions>' doesn't exist #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -160,7 +160,7 @@ private bool DoesTableExist() | |||
| /// <returns>True if table exists, false otherwise</returns> | |||
| private bool VerifyTableExistsCommand(IDbCommand command, string tableName, string schemaName) | |||
| { | |||
| command.CommandText = string.IsNullOrEmpty(schema) | |||
| command.CommandText = string.IsNullOrEmpty(schemaName) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying to a newly created MySql database, but there are existing databases with schemaversions table created (and you don't explicitly define the name of the database), the VerifiyTableExistsCommand falls back on a SQL query that will return a false result.
This to avoid this, you needs to ensure that the database name is always defined. If you only pass in a connection string, this doesn't happen. I have thus added some functionaility that if no schema is passed in, then look at the connection string. If it finds a schema name in the connection string use it, else default to the schema name as null