Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change output of debug.log on Masternodeoperators #648

Closed
Stonygan opened this issue Jul 30, 2021 · 2 comments · Fixed by #1006
Closed

Change output of debug.log on Masternodeoperators #648

Stonygan opened this issue Jul 30, 2021 · 2 comments · Fixed by #1006

Comments

@Stonygan
Copy link

to discuss:

Part 1:
debug=staking:

  • to much output for a longer operating in production with debugmode staking, but without, we have too less infos for a minted block and cant monitor chainsplits or rollbacks.
    Proposal: Add following lines to normal Logmode without debug=staking
    2021-05-05T17:19:45Z MakeStake: kernel found
    2021-05-05T17:19:45Z new proof-of-stake block found hash: 067cf6f79e103ffa735bd110847ee37ea7beec5e935c6ac7b780e6288361ca9c

    2021-05-05T17:19:45Z UpdateTip: new best=067cf6f79e103ffa735bd110847ee37ea7beec5e935c6ac7b780e6288361ca9c height=82789......
    2021-05-05T17:19:45Z ThreadStaker (f2bb742370d0045359bdc3c371b382fbaa42dfce): minted a block!

atm only the last two lines are in debug.log without debug=staking

Part 2:
reduce Loglevel when debug=staking is disabled:

Without debug=staking, the debug.log is flooded with

2021-07-30T12:20:17Z ThreadStaker: (833......db786ce) waiting init...
2021-07-30T12:20:17Z ThreadStaker: (811......5239e28) waiting init...
2021-07-30T12:20:17Z ThreadStaker: (9bf......a7cd4bc) waiting init...
2021-07-30T12:20:18Z ThreadStaker: (dc9......c1ff8f5) waiting init...
2021-07-30T12:20:18Z ThreadStaker: (538......89e6a5c) waiting init...
2021-07-30T12:20:18Z ThreadStaker: (bd8......972b8f7) waiting init...
2021-07-30T12:20:18Z ThreadStaker: (41d......aa3a40f) waiting init...
2021-07-30T12:20:18Z ThreadStaker: (051......934da91) waiting init...
2021-07-30T12:20:18Z ThreadStaker: (591......76c8594) waiting init...
2021-07-30T12:20:18Z ThreadStaker: (16b......c63ff78) waiting init...
2021-07-30T12:20:18Z ThreadStaker: (968......2dfe46e) waiting init...

In my oppinion Operators with waiting init must only visible with debug=staking or we need another switch to turn off this info in debug.log.

What do you think, maybe you have special reasons for this behavior?

@defichain-bot
Copy link
Member

@Stonygan: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@chrizog
Copy link
Contributor

chrizog commented Dec 25, 2021

I want to take a look at this as a first issue for contributing.

I wonder how I can start a masternode on regtest.

When trying to use generatetoaddress 1 "address" RPC it tells me that I need to operate a masternode. However, I cannot operate a masternode if the blockchain height is zero. I cannot figure out how to first get the blockchain and the needed DFI for a masternode and then start operating a masternode, if I need a masternode first to this. (deadlock).
Can someone elaborate on this please?

chrizog added a commit to chrizog/ain that referenced this issue Dec 28, 2021
chrizog added a commit to chrizog/ain that referenced this issue Dec 28, 2021
chrizog added a commit to chrizog/ain that referenced this issue Jan 2, 2022
prasannavl added a commit that referenced this issue Mar 18, 2022
* Correct loglevel for ThreadStaker (#648)

* No debug level for MakeStake kernel found (#648)

* Time throttled logging for staker (#648)

* Reverse logic in log time throttle filter

* Simplify throttled logging

* Minor refactors

Co-authored-by: Prasanna Loganathar <pvl@prasannavl.com>
Co-authored-by: Jouzo <jdesclercs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants