1.5.x #227
Merged
1.5.x #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>
Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>
Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>
Regtest use mainnet params. Always apply quorum check on anchors read from Bitcoin, invalidates all current anchors. Do not show old anchors in listanchors. Use correct iterator in loop. Post-AMK logic always true in CreateNewBlock payment code. spv_createanchor requires SPV to fully validate anchor auths. Set realistic times in fake SPV Bitcoin TXs. Update C++ anchor unit tests.
Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>
ShengguangXiao
pushed a commit
that referenced
this pull request
Mar 15, 2021
partially implement setrawprice Signed-off-by: DeFiDev <defidev@cakedefi.com> refactor oracles Signed-off-by: DeFiDev <defidev@cakedefi.com> refactore according to changed design Signed-off-by: DeFiDev <defidev@cakedefi.com> refactor oracles, implement oraclesview, partially implement setoracledata Signed-off-by: DeFiDev <defidev@cakedefi.com> partially fix setoracledata method Signed-off-by: DeFiDev <defidev@cakedefi.com> get rid of timestamp type Signed-off-by: DeFiDev <defidev@cakedefi.com> fix style issue Signed-off-by: DeFiDev <defidev@cakedefi.com> debug setoracledata, fix errors Signed-off-by: DeFiDev <defidev@cakedefi.com> remove HasOracleAuth impl refactor oracle view, add appointoracle Signed-off-by: DeFiDev <defidev@cakedefi.com> correct parse address Signed-off-by: DeFiDev <defidev@cakedefi.com> implementing rpc methods Signed-off-by: DeFiDev <defidev@cakedefi.com> debugging feature oracles Signed-off-by: DeFiDev <defidev@cakedefi.com> set correct oracle address Signed-off-by: DeFiDev <defidev@cakedefi.com> debugging oracles in progress Signed-off-by: DeFiDev <defidev@cakedefi.com> debugging in process Signed-off-by: DeFiDev <defidev@cakedefi.com> debugging in process Signed-off-by: DeFiDev <defidev@cakedefi.com> fix few errors, debugging almost completed Signed-off-by: DeFiDev <defidev@cakedefi.com> added update oracle method, refactored code Signed-off-by: DeFiDev <defidev@cakedefi.com> implemented listlatestprices Signed-off-by: DeFiDev <defidev@cakedefi.com> add getprice Signed-off-by: DeFiDev <defidev@cakedefi.com> refactor listlatestrawprices Signed-off-by: DeFiDev <defidev@cakedefi.com> refactoring oracles to use different currencies. in process, isn't compilable yet Signed-off-by: DeFiDev <defidev@cakedefi.com> make oracles use currencies Signed-off-by: DeFiDev <defidev@cakedefi.com> refactor, make proper auth, small fixes Signed-off-by: DeFiDev <defidev@cakedefi.com> fix iteration error Signed-off-by: DeFiDev <defidev@cakedefi.com> fix error in logic Signed-off-by: DeFiDev <defidev@cakedefi.com> implement listprices Signed-off-by: DeFiDev <defidev@cakedefi.com> refactor Signed-off-by: DeFiDev <defidev@cakedefi.com> refactor allowed pairs parameter for appointoracle and updateoracle Signed-off-by: DeFiDev <defidev@cakedefi.com> add txs parameters check before sending, debugging updateoracle, removeoracle, setoracledata Signed-off-by: DeFiDev <defidev@cakedefi.com> debug updateoracle & removeoracle Signed-off-by: DeFiDev <defidev@cakedefi.com> added getpricefeeds rpc method Signed-off-by: DeFiDev <defidev@cakedefi.com> fixed getpricefeeds Signed-off-by: DeFiDev <defidev@cakedefi.com> fix problem with transactions, remove debug code Signed-off-by: DeFiDev <defidev@cakedefi.com> add tokens formatting Signed-off-by: DeFiDev <defidev@cakedefi.com> implementing tests in progress Signed-off-by: DeFiDev <defidev@cakedefi.com> fix mistakes Signed-off-by: DeFiDev <defidev@cakedefi.com> implement most test cases Signed-off-by: DeFiDev <defidev@cakedefi.com> implement more test cases, make workaround for error code 0 Signed-off-by: DeFiDev <defidev@cakedefi.com> correct updateoracle to preserve existing prices Signed-off-by: DeFiDev <defidev@cakedefi.com> fix tests after correcting updateoracle, add check for expiration Signed-off-by: DeFiDev <defidev@cakedefi.com> Fix sendtokentoaddress account selection mode Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Return operator != in auto select balances Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Fix potential node syncing issues on Travis Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Add ability for multiple operators per node Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Fix test runner Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Prevent sending DFI tokens to non-self addresses by default Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Update cache of owned addresses Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Fix gettokenbalances Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Fix metadata in poolswap rpc call Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Add checkpoint data Minimize custom tx logs Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Show log on new tip every 20 seconds Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Remove duplicate anchor reward log Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Increase file chunk size Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Include watch addresses to acindex-mineonly Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Search in for watch addresses always in mine table as well as in wallet Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Try blocking only dfi token Std pair Remove unused variable Fix unit test Fix unit test Fix unit test Add custom_tx option in listtransaction rpc Change option to exlude custom transactions Set default value of exclude_custom_tx to false, add unittest Fix lint error Show address instead of script as pool owner Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Fix auto select accounts Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Added checkpoint Add AutoAuthPrep meta data to auto auth TXs Invalidate last checkpoint block to reconsider invalid blocks Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Strip out spam syncing block header messages Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Add explicit check for invalid blocks Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Update validation.cpp Some small tidyup Added stale bot Added stale bot Prevent downgrade to genesis block on wrong chain Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Do not read stream out of its bounds in FindByte Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Do not search in wallet for custom tx type Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Check for watch address change Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Don't call lsn_reset in periodic flush Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Make wallet more reponsive and less buggy Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Added stale bot Added stale bot Prevent downgrade to genesis block on wrong chain Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Limit size of wallet tx. Strip out dead wallet code Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Fix operator lower precedence warning Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Add lock free guard mechanism Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Use cached version of wallet filter type. Strip out more dead code Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Do not read stream out of its bounds in FindByte Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Fix wallet watch only address visibility Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Yield a slot to other staker threads Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Pin github-actions to a full length commit SHA (#226) 1.5.x (#227) * Dakota fork logic * SPV logging category * Add Dakota to getblockchaininfo * Make update token only need owner auth * Open createpoorpair after dakota fork and add unittest * Fix unittest fail * Address review comments * Fix unittest fail * Fix swap max price calculation Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> * Reduce collateral amount for masternode creation Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> * Unit tests masternode collateral amount creation Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> * Revert "Make update token only need owner auth" * Anchor refactor * Reverse community balance on reorg * Minor changes and corrections Regtest use mainnet params. Always apply quorum check on anchors read from Bitcoin, invalidates all current anchors. Do not show old anchors in listanchors. Use correct iterator in loop. Post-AMK logic always true in CreateNewBlock payment code. spv_createanchor requires SPV to fully validate anchor auths. Set realistic times in fake SPV Bitcoin TXs. Update C++ anchor unit tests. * Log genesis block errors. Useful for debugging unexpected cases. * Anchor functional test updates for Dakota * Fork out NotAllowedToFail (#223) Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> * Set Dakota fork heights * Update chainparams.cpp Co-authored-by: Peter Bushnell <bushsolo@gmail.com> Co-authored-by: ShengguangXiao <shengguangxiao@gmail.com> Co-authored-by: Anthony Fieroni <bvbfan@abv.bg> Adding variable for make args, ignore .vscode dir (#228) Do not throw in case of account error at rewards redistribution (#230) * Do not throw in case of account error at rewards redistribution Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> * Sync nodes after reset balance in wallet avoid reuse test Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> * Fix nodes out of sync in custom rewards test Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Moved security policy from issue into repo. (#237) * Moved security policy from issue into repo. (GitHub recommended) * Changed 20,000 DFI to 50,000 USD worth of DFI Branding consistency for README.md (#243) DeFi Blockchain to DeFiChain License update (#245) Co-authored-by: Ahmed Hilali <monstrobishi@gmail.com> Setup CODEOWNERS (#242) Co-authored-by: Ahmed Hilali <monstrobishi@gmail.com> OSS Governance Bot setup for PR & Issue (#241) Labels syncing automation (#240) Automated release drafting (#239) Setup issue template for governance agility (#238) Remove storing pre-fork anchor reward (#235) Co-authored-by: Ahmed Hilali <monstrobishi@gmail.com> Add ability to interrupt long-standing revert to previous checkpoint (#233) * Respect shutdown request at block disconnect to previous checkpoint Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> * Add new checkpoints Co-authored-by: Ahmed Hilali <monstrobishi@gmail.com> Reject protocol versions less than 70016 (#236) * Reject protocol versions less than 70016 * Increment version in tests Co-authored-by: Ahmed Hilali <monstrobishi@gmail.com> Improve anchor API help message (#246) Co-authored-by: Ahmed Hilali <monstrobishi@gmail.com> Refactor mn_rpc file and split into different categories based on RPC types (#234) * Initial rpc refactor to categories files * Clean up * Added include guard and ran clang-format * Adding new lines to file end * Fix lint error * Adding missing masternodes/mn_rpc.h to Makefile.am * Register rpc commands in its own files * Add new rpc files to check-rpc-mappings.py Co-authored-by: Ahmed Hilali <monstrobishi@gmail.com> All anchors and validation moved to pending (#249) Reject paid confirmations. Only vote if not in IBD. (#253) Restore handling of equal work in block when invalidating blocks (#229) Co-authored-by: Ahmed Hilali <monstrobishi@gmail.com> Update setup-masternodes.md (#247) SPV: hard code required spv solution to related network. (#248) Co-authored-by: Ahmed Hilali <monstrobishi@gmail.com> Wipe confs and revote after new team. New getactivemasternodes call. (#254) Flush when it's needed in reindex chainstate (#255) Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Wait wallet unlock to stake (#256) Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> fix merge issues Signed-off-by: DeFiDev <defidev@cakedefi.com> replaced getpricefeeds with getoracledata, refactor tests Signed-off-by: DeFiDev <defidev@cakedefi.com> Fix oracle rpc api bugs (#276) * Fix oracle rpc api bugs * fix remaining issues Signed-off-by: DeFiDev <defidev@cakedefi.com> Co-authored-by: DeFiDev <defidev@cakedefi.com>
ShengguangXiao
pushed a commit
that referenced
this pull request
Mar 15, 2021
partially implement setrawprice Signed-off-by: DeFiDev <defidev@cakedefi.com> refactor oracles Signed-off-by: DeFiDev <defidev@cakedefi.com> refactore according to changed design Signed-off-by: DeFiDev <defidev@cakedefi.com> refactor oracles, implement oraclesview, partially implement setoracledata Signed-off-by: DeFiDev <defidev@cakedefi.com> partially fix setoracledata method Signed-off-by: DeFiDev <defidev@cakedefi.com> get rid of timestamp type Signed-off-by: DeFiDev <defidev@cakedefi.com> fix style issue Signed-off-by: DeFiDev <defidev@cakedefi.com> debug setoracledata, fix errors Signed-off-by: DeFiDev <defidev@cakedefi.com> remove HasOracleAuth impl refactor oracle view, add appointoracle Signed-off-by: DeFiDev <defidev@cakedefi.com> correct parse address Signed-off-by: DeFiDev <defidev@cakedefi.com> implementing rpc methods Signed-off-by: DeFiDev <defidev@cakedefi.com> debugging feature oracles Signed-off-by: DeFiDev <defidev@cakedefi.com> set correct oracle address Signed-off-by: DeFiDev <defidev@cakedefi.com> debugging oracles in progress Signed-off-by: DeFiDev <defidev@cakedefi.com> debugging in process Signed-off-by: DeFiDev <defidev@cakedefi.com> debugging in process Signed-off-by: DeFiDev <defidev@cakedefi.com> fix few errors, debugging almost completed Signed-off-by: DeFiDev <defidev@cakedefi.com> added update oracle method, refactored code Signed-off-by: DeFiDev <defidev@cakedefi.com> implemented listlatestprices Signed-off-by: DeFiDev <defidev@cakedefi.com> add getprice Signed-off-by: DeFiDev <defidev@cakedefi.com> refactor listlatestrawprices Signed-off-by: DeFiDev <defidev@cakedefi.com> refactoring oracles to use different currencies. in process, isn't compilable yet Signed-off-by: DeFiDev <defidev@cakedefi.com> make oracles use currencies Signed-off-by: DeFiDev <defidev@cakedefi.com> refactor, make proper auth, small fixes Signed-off-by: DeFiDev <defidev@cakedefi.com> fix iteration error Signed-off-by: DeFiDev <defidev@cakedefi.com> fix error in logic Signed-off-by: DeFiDev <defidev@cakedefi.com> implement listprices Signed-off-by: DeFiDev <defidev@cakedefi.com> refactor Signed-off-by: DeFiDev <defidev@cakedefi.com> refactor allowed pairs parameter for appointoracle and updateoracle Signed-off-by: DeFiDev <defidev@cakedefi.com> add txs parameters check before sending, debugging updateoracle, removeoracle, setoracledata Signed-off-by: DeFiDev <defidev@cakedefi.com> debug updateoracle & removeoracle Signed-off-by: DeFiDev <defidev@cakedefi.com> added getpricefeeds rpc method Signed-off-by: DeFiDev <defidev@cakedefi.com> fixed getpricefeeds Signed-off-by: DeFiDev <defidev@cakedefi.com> fix problem with transactions, remove debug code Signed-off-by: DeFiDev <defidev@cakedefi.com> add tokens formatting Signed-off-by: DeFiDev <defidev@cakedefi.com> implementing tests in progress Signed-off-by: DeFiDev <defidev@cakedefi.com> fix mistakes Signed-off-by: DeFiDev <defidev@cakedefi.com> implement most test cases Signed-off-by: DeFiDev <defidev@cakedefi.com> implement more test cases, make workaround for error code 0 Signed-off-by: DeFiDev <defidev@cakedefi.com> correct updateoracle to preserve existing prices Signed-off-by: DeFiDev <defidev@cakedefi.com> fix tests after correcting updateoracle, add check for expiration Signed-off-by: DeFiDev <defidev@cakedefi.com> Fix sendtokentoaddress account selection mode Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Return operator != in auto select balances Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Fix potential node syncing issues on Travis Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Add ability for multiple operators per node Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Fix test runner Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Prevent sending DFI tokens to non-self addresses by default Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Update cache of owned addresses Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Fix gettokenbalances Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Fix metadata in poolswap rpc call Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Add checkpoint data Minimize custom tx logs Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Show log on new tip every 20 seconds Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Remove duplicate anchor reward log Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Increase file chunk size Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Include watch addresses to acindex-mineonly Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Search in for watch addresses always in mine table as well as in wallet Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Try blocking only dfi token Std pair Remove unused variable Fix unit test Fix unit test Fix unit test Add custom_tx option in listtransaction rpc Change option to exlude custom transactions Set default value of exclude_custom_tx to false, add unittest Fix lint error Show address instead of script as pool owner Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Fix auto select accounts Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Added checkpoint Add AutoAuthPrep meta data to auto auth TXs Invalidate last checkpoint block to reconsider invalid blocks Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Strip out spam syncing block header messages Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Add explicit check for invalid blocks Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Update validation.cpp Some small tidyup Added stale bot Added stale bot Prevent downgrade to genesis block on wrong chain Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Do not read stream out of its bounds in FindByte Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Do not search in wallet for custom tx type Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Check for watch address change Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Don't call lsn_reset in periodic flush Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Make wallet more reponsive and less buggy Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Added stale bot Added stale bot Prevent downgrade to genesis block on wrong chain Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Limit size of wallet tx. Strip out dead wallet code Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Fix operator lower precedence warning Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Add lock free guard mechanism Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Use cached version of wallet filter type. Strip out more dead code Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Do not read stream out of its bounds in FindByte Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Fix wallet watch only address visibility Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Yield a slot to other staker threads Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Pin github-actions to a full length commit SHA (#226) 1.5.x (#227) * Dakota fork logic * SPV logging category * Add Dakota to getblockchaininfo * Make update token only need owner auth * Open createpoorpair after dakota fork and add unittest * Fix unittest fail * Address review comments * Fix unittest fail * Fix swap max price calculation Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> * Reduce collateral amount for masternode creation Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> * Unit tests masternode collateral amount creation Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> * Revert "Make update token only need owner auth" * Anchor refactor * Reverse community balance on reorg * Minor changes and corrections Regtest use mainnet params. Always apply quorum check on anchors read from Bitcoin, invalidates all current anchors. Do not show old anchors in listanchors. Use correct iterator in loop. Post-AMK logic always true in CreateNewBlock payment code. spv_createanchor requires SPV to fully validate anchor auths. Set realistic times in fake SPV Bitcoin TXs. Update C++ anchor unit tests. * Log genesis block errors. Useful for debugging unexpected cases. * Anchor functional test updates for Dakota * Fork out NotAllowedToFail (#223) Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> * Set Dakota fork heights * Update chainparams.cpp Co-authored-by: Peter Bushnell <bushsolo@gmail.com> Co-authored-by: ShengguangXiao <shengguangxiao@gmail.com> Co-authored-by: Anthony Fieroni <bvbfan@abv.bg> Adding variable for make args, ignore .vscode dir (#228) Do not throw in case of account error at rewards redistribution (#230) * Do not throw in case of account error at rewards redistribution Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> * Sync nodes after reset balance in wallet avoid reuse test Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> * Fix nodes out of sync in custom rewards test Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Moved security policy from issue into repo. (#237) * Moved security policy from issue into repo. (GitHub recommended) * Changed 20,000 DFI to 50,000 USD worth of DFI Branding consistency for README.md (#243) DeFi Blockchain to DeFiChain License update (#245) Co-authored-by: Ahmed Hilali <monstrobishi@gmail.com> Setup CODEOWNERS (#242) Co-authored-by: Ahmed Hilali <monstrobishi@gmail.com> OSS Governance Bot setup for PR & Issue (#241) Labels syncing automation (#240) Automated release drafting (#239) Setup issue template for governance agility (#238) Remove storing pre-fork anchor reward (#235) Co-authored-by: Ahmed Hilali <monstrobishi@gmail.com> Add ability to interrupt long-standing revert to previous checkpoint (#233) * Respect shutdown request at block disconnect to previous checkpoint Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> * Add new checkpoints Co-authored-by: Ahmed Hilali <monstrobishi@gmail.com> Reject protocol versions less than 70016 (#236) * Reject protocol versions less than 70016 * Increment version in tests Co-authored-by: Ahmed Hilali <monstrobishi@gmail.com> Improve anchor API help message (#246) Co-authored-by: Ahmed Hilali <monstrobishi@gmail.com> Refactor mn_rpc file and split into different categories based on RPC types (#234) * Initial rpc refactor to categories files * Clean up * Added include guard and ran clang-format * Adding new lines to file end * Fix lint error * Adding missing masternodes/mn_rpc.h to Makefile.am * Register rpc commands in its own files * Add new rpc files to check-rpc-mappings.py Co-authored-by: Ahmed Hilali <monstrobishi@gmail.com> All anchors and validation moved to pending (#249) Reject paid confirmations. Only vote if not in IBD. (#253) Restore handling of equal work in block when invalidating blocks (#229) Co-authored-by: Ahmed Hilali <monstrobishi@gmail.com> Update setup-masternodes.md (#247) SPV: hard code required spv solution to related network. (#248) Co-authored-by: Ahmed Hilali <monstrobishi@gmail.com> Wipe confs and revote after new team. New getactivemasternodes call. (#254) Flush when it's needed in reindex chainstate (#255) Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Wait wallet unlock to stake (#256) Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> fix merge issues Signed-off-by: DeFiDev <defidev@cakedefi.com> replaced getpricefeeds with getoracledata, refactor tests Signed-off-by: DeFiDev <defidev@cakedefi.com> Fix oracle rpc api bugs (#276) * Fix oracle rpc api bugs * fix remaining issues Signed-off-by: DeFiDev <defidev@cakedefi.com> Co-authored-by: DeFiDev <defidev@cakedefi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull requests without a rationale and clear improvement may be closed
immediately.
Please provide clear motivation for your patch and explain how it improves
DeFi Blockchain user experience or the DeFi Blockchain developer experience
significantly.
src/test/) orfunctional tests (see
test/). Contributors should note which tests covermodified code. If no tests exist for a region of modified code, new tests
should accompany the change.
explanation of the potential issue as well as reasoning for the way the bug
was fixed.
If a feature is based on a lot of dependencies, contributors should first
consider building the system outside of DeFi Blockchain, if possible.
bug fix or otherwise improve developer experience significantly. For example,
most "code style" refactoring changes require a thorough explanation why they
are useful, what downsides they have and why they significantly improve
developer experience or avoid serious programming bugs. Note that code style
is often a subjective matter. Unless they are explicitly mentioned to be
preferred in the developer notes, stylistic code
changes are usually rejected.
DeFi Blockchain has a thorough review process and even the most trivial change
needs to pass a lot of eyes and requires non-zero or even substantial time
effort to review. There is a huge lack of active reviewers on the project, so
patches often sit for a long time.