Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR sets the ground work for the tracer revamp. This minimally fixes the debug_traceTransaction RPC to use to correct state.
The RPC pipeline should use the previous block hash state root instead of the state root of the block that the replaying transaction was minted in.
Add in functional test for tracer related RPCs.
To do in the future: add tracer test support in metachain test suites.
Note that trace transaction pipeline is still faulty when replaying a tx with dependent txs in the same block. The fixes will be in in the upcoming tracer revamp PR. The rationale for this is because the correct tracer fixes will revamp the entire design and thus will be leaving this fixes in the subsequent PR.
Note that because of the above, the dependency tx test inside the rpc_tracer test is disabled for now.
Storage
Consensus