Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM: Fix trace transaction state #2841

Merged
merged 7 commits into from
Mar 11, 2024
Merged

EVM: Fix trace transaction state #2841

merged 7 commits into from
Mar 11, 2024

Conversation

sieniven
Copy link
Member

@sieniven sieniven commented Mar 4, 2024

Summary

This PR sets the ground work for the tracer revamp. This minimally fixes the debug_traceTransaction RPC to use to correct state.

  • The RPC pipeline should use the previous block hash state root instead of the state root of the block that the replaying transaction was minted in.

  • Add in functional test for tracer related RPCs.

  • To do in the future: add tracer test support in metachain test suites.

  • Note that trace transaction pipeline is still faulty when replaying a tx with dependent txs in the same block. The fixes will be in in the upcoming tracer revamp PR. The rationale for this is because the correct tracer fixes will revamp the entire design and thus will be leaving this fixes in the subsequent PR.

  • Note that because of the above, the dependency tx test inside the rpc_tracer test is disabled for now.

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl merged commit 69db854 into master Mar 11, 2024
15 of 16 checks passed
@prasannavl prasannavl deleted the niven/fix-trace-state branch March 11, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants