Skip to content
This repository has been archived by the owner on Aug 24, 2023. It is now read-only.

chore(docs): add draft of MetaChain consensus #101

Merged
merged 5 commits into from
Sep 18, 2022

Conversation

fuxingloh
Copy link
Contributor

@fuxingloh fuxingloh commented Sep 15, 2022

What this PR does / why we need it:

As per the title, this PR is a working draft version of MetaChain Consensus.

@netlify
Copy link

netlify bot commented Sep 15, 2022

Deploy Preview for metachain ready!

Name Link
🔨 Latest commit 0dc475c
🔍 Latest deploy log https://app.netlify.com/sites/metachain/deploys/63273c2944cb620009f176f0
😎 Deploy Preview https://deploy-preview-101--metachain.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fuxingloh fuxingloh temporarily deployed to Release Docker September 15, 2022 17:15 Inactive
@defichain-bot defichain-bot added area/docs kind/chore Non feature change labels Sep 15, 2022
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #101 (0dc475c) into main (6251c1b) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #101   +/-   ##
=====================================
  Coverage   8.21%   8.21%           
=====================================
  Files         16      16           
  Lines       1814    1814           
  Branches      14      14           
=====================================
  Hits         149     149           
  Misses      1664    1664           
  Partials       1       1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 15, 2022

Docker image for defich/metachain is ready!

Built with commit e6a10d5

  • docker pull ghcr.io/defich/metachain:e6a10d5bbebdd84a433b77cb854df7e5698887ee
  • docker pull ghcr.io/defich/metachain:pr-101

@fuxingloh fuxingloh temporarily deployed to Release Docker September 16, 2022 05:16 Inactive
@fuxingloh fuxingloh marked this pull request as ready for review September 16, 2022 05:22
Copy link
Contributor

@eli-lim eli-lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits

docs/:300:MetaChain Protocol/:200:consensus.md Outdated Show resolved Hide resolved
docs/:300:MetaChain Protocol/:200:consensus.md Outdated Show resolved Hide resolved
docs/:300:MetaChain Protocol/:200:consensus.md Outdated Show resolved Hide resolved
Copy link

@weiyuan95 weiyuan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looking forward to seeing the white paper.

Co-authored-by: Eli <31790206+eli-lim@users.noreply.github.com>
Signed-off-by: Fuxing Loh <4266087+fuxingloh@users.noreply.github.com>
@fuxingloh fuxingloh temporarily deployed to Release Docker September 16, 2022 10:30 Inactive
weiyuan95
weiyuan95 previously approved these changes Sep 16, 2022
eli-lim
eli-lim previously approved these changes Sep 17, 2022
@fuxingloh fuxingloh dismissed stale reviews from eli-lim and weiyuan95 via 0dc475c September 18, 2022 15:41
@fuxingloh fuxingloh temporarily deployed to Release Docker September 18, 2022 15:41 Inactive
@fuxingloh fuxingloh merged commit 9799411 into main Sep 18, 2022
@fuxingloh fuxingloh deleted the fuxingloh/docs-consensus branch September 18, 2022 16:15
@fuxingloh fuxingloh mentioned this pull request Sep 19, 2022
11 tasks
canonbrother pushed a commit that referenced this pull request Sep 28, 2022
#### What this PR does / why we need it:

As per the title, this PR is a working draft version of MetaChain
Consensus.

Signed-off-by: Fuxing Loh <4266087+fuxingloh@users.noreply.github.com>
Co-authored-by: Eli <31790206+eli-lim@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs kind/chore Non feature change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants