Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tabbing on read only fields #96

Merged
merged 5 commits into from
May 11, 2020
Merged

Conversation

gregbty
Copy link
Collaborator

@gregbty gregbty commented Mar 7, 2020

This disables tabbing on read only fields so that they don't trigger things like validation by exposing a new tabIndex prop.

@codecov
Copy link

codecov bot commented Mar 7, 2020

Codecov Report

Merging #96 into master will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   46.87%   46.88%   +0.01%     
==========================================
  Files          54       54              
  Lines        1681     1687       +6     
  Branches      304      308       +4     
==========================================
+ Hits          788      791       +3     
- Misses        828      831       +3     
  Partials       65       65
Impacted Files Coverage Δ
...ld-host-renderer/field-host-renderer.component.tsx 16.35% <33.33%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99a314f...b2c4421. Read the comment docs.

@gregbty gregbty marked this pull request as ready for review March 7, 2020 00:39
@gregbty gregbty merged commit 45e8677 into master May 11, 2020
@gregbty gregbty deleted the disable-tab-read-only branch May 11, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant